Page MenuHomePhabricator
Differential D135874

[mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR.
ClosedPublic
Actions

Authored by gysit on Oct 13 2022, 6:59 AM.

Details

Reviewers
ftynse
nicolasvasilache
dcaballe
Commits
rG7114185f4e51: [mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR.
Summary

The revision imports the extract and insert value operations using
tablegen generated builders. Additionally, it moves the tests to
the instructions.ll test file.

Diff Detail

Event Timeline

gysit created this revision.Oct 13 2022, 6:59 AM
Herald added a reviewer: ftynse. · View Herald TranscriptOct 13 2022, 6:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: zero9178, bzcheeseman, awarzynski and 20 others. · View Herald Transcript
gysit requested review of this revision.Oct 13 2022, 6:59 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptOct 13 2022, 6:59 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B191956: Diff 467460.Oct 13 2022, 7:16 AM
gysit updated this revision to Diff 467472.Oct 13 2022, 7:57 AM

Move tests close to the extract/insert element tests.

Harbormaster completed remote builds in B191964: Diff 467472.Oct 13 2022, 8:12 AM
gysit added a child revision: D135880: [mlir][llvm] Use tablegen to import shufflevector from LLVM IR..Oct 13 2022, 8:12 AM
ftynse accepted this revision.Oct 13 2022, 8:23 AM
This revision is now accepted and ready to land.Oct 13 2022, 8:23 AM
dcaballe accepted this revision.Oct 13 2022, 2:57 PM
Closed by commit rG7114185f4e51: [mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR. (authored by gysit). · Explain WhyOct 14 2022, 12:10 AM
This revision was automatically updated to reflect the committed changes.
gysit added a commit: rG7114185f4e51: [mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR..

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
12 lines
lib/
Target/
LLVMIR/
28 lines
test/
Target/
LLVMIR/
Import/
30 lines
35 lines

Diff 467696

View Options

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Loading...
View Options

mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp

Loading...
View Options

mlir/test/Target/LLVMIR/Import/basic.ll

Loading...
View Options

mlir/test/Target/LLVMIR/Import/instructions.ll

Loading...