This is an archive of the discontinued LLVM Phabricator instance.

Precommit for SWDEV-353076: Add check directives to existing tests.
ClosedPublic

Authored by Leonc on Oct 12 2022, 9:31 AM.

Details

Summary

Add FileCheck directives to existing tests in preparation for new tests.

Diff Detail

Event Timeline

Leonc created this revision.Oct 12 2022, 9:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 9:31 AM
Leonc requested review of this revision.Oct 12 2022, 9:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 9:31 AM
arsenm added inline comments.Oct 12 2022, 9:35 AM
llvm/test/CodeGen/AMDGPU/fnearbyint.ll
2

Can add a common GCN prefix, the SI and CI cases are mostly identical

Leonc added inline comments.Oct 12 2022, 9:39 AM
llvm/test/CodeGen/AMDGPU/fnearbyint.ll
2

I got a warning from the update script when I did that. Can it be safely ignored?

WARNING: Prefix GCN had conflicting output from different RUN lines for all functions in test ../llvm/test/CodeGen/AMDGPU/fnearbyint.ll
arsenm accepted this revision.Oct 12 2022, 9:41 AM
arsenm added inline comments.
llvm/test/CodeGen/AMDGPU/fnearbyint.ll
2

Yes

This revision is now accepted and ready to land.Oct 12 2022, 9:41 AM
Leonc updated this revision to Diff 467179.Oct 12 2022, 9:58 AM
  • Add GCN prefix.
Leonc marked 2 inline comments as done.Oct 12 2022, 9:59 AM
arsenm added inline comments.Oct 12 2022, 9:59 AM
llvm/test/CodeGen/AMDGPU/fnearbyint.ll
354–355

If it doesn't make a difference, remove this and drop the prefix

Leonc updated this revision to Diff 467180.Oct 12 2022, 10:04 AM
  • Revert GCN prefixes.
Leonc marked an inline comment as done.Oct 12 2022, 10:05 AM
arsenm accepted this revision.Oct 12 2022, 10:27 AM
This revision was landed with ongoing or failed builds.Oct 13 2022, 12:03 AM
This revision was automatically updated to reflect the committed changes.
foad added inline comments.Oct 17 2022, 3:04 AM
llvm/test/CodeGen/AMDGPU/fnearbyint.ll
2

I added a common SICI prefix in 0c22f4f5fe44.