[clang][LTO] Remove the use of `--` for arange option

[qiongsiwu1]

Summary

https://reviews.llvm.org/D134668 removed all -- (double dashes) when using plugin-opt to pass linker options and replaced them with -. https://reviews.llvm.org/D133092 was committed later but introduced an instance of --. This patch replaces the -- with -.

[qiongsiwu1]

Fix a patch upload error.

[MaskRay]

I missed https://reviews.llvm.org/D134668 . See my comment there I don't think the change is necessary.

[qiongsiwu1]

In D135400#3841321, @MaskRay wrote:

I missed https://reviews.llvm.org/D134668 . See my comment there I don't think the change is necessary.

Thanks for the comment! I posted a reply there.

[MaskRay]

clang/test/Driver/debug-options-aranges.c

6

[qiongsiwu1]

Thanks for the review! Comment addressed.

clang/lib/Driver/ToolChains/CommonArgs.cpp

#endif
     CmdArgs.push_back(Args.MakeArgString(Plugin));
   }
 
   // Note, this solution is far from perfect, better to encode it into IR
   // metadata, but this may not be worth it, since it looks like aranges is on
   // the way out.
   if (Args.hasArg(options::OPT_gdwarf_aranges)) {
     CmdArgs.push_back(
-        Args.MakeArgString("--plugin-opt=-generate-arange-section"));
+        Args.MakeArgString("-plugin-opt=-generate-arange-section"));
   }
 
   // Try to pass driver level flags relevant to LTO code generation down to
   // the plugin.
 
   // Handle flags for selecting CPU variants.
   std::string CPU = getCPUName(D, Args, ToolChain.getTriple());
   if (!CPU.empty())

clang/test/Driver/debug-options-aranges.c

 // REQUIRES: lld
 
 /// Check that the linker plugin will get -generate-arange-section.
 // RUN: %clang -### -g --target=x86_64-linux -flto      -gdwarf-aranges %s 2>&1 | FileCheck %s
 // RUN: %clang -### -g --target=x86_64-linux -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck %s
-// CHECK: --plugin-opt=-generate-arange-section
+// CHECK: "-plugin-opt=-generate-arange-section"