This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Make the exec_mode global have protected visibility
ClosedPublic

Authored by jhuber6 on Oct 5 2022, 10:10 AM.

Details

Summary

We use protected visibility for almost everything with offloading. This
is because it provides us with the ability to read things from the host
without the expectation that it will be preempted by a shared library
load, bugs related to this have happened when offloading to the host.
This patch just makes the exec_mode global generated for each plugin
have protected visibility.

Diff Detail

Event Timeline

jhuber6 created this revision.Oct 5 2022, 10:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 10:10 AM
jhuber6 requested review of this revision.Oct 5 2022, 10:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 10:10 AM
jdoerfert accepted this revision.Oct 5 2022, 10:27 AM
This revision is now accepted and ready to land.Oct 5 2022, 10:27 AM