This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Annotate the intrinsics to be default and nocallback
ClosedPublic

Authored by jdoerfert on Oct 4 2022, 6:24 AM.

Diff Detail

Event Timeline

jdoerfert created this revision.Oct 4 2022, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 6:24 AM
jdoerfert requested review of this revision.Oct 4 2022, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 6:24 AM
jdoerfert updated this revision to Diff 464995.Oct 4 2022, 6:36 AM

update AMDGPU tests

arsenm added inline comments.Oct 4 2022, 8:11 AM
llvm/include/llvm/IR/Intrinsics.td
515

Probably best to assume this has side effects

llvm/include/llvm/IR/IntrinsicsAMDGPU.td
168

I thought WIllReturn was in the default set?

209

I'm not sure sendmsg* should be no IntrNoCallback. You can use it for device to host messaging, which I guess could trigger some visible change

273

IntrWillReturn default

arsenm added inline comments.Oct 4 2022, 8:53 AM
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
467

NoFree

495

NoFree

993

This can use Default

1079

Can be default

1102

NoFree

1175

Can be default

1241

All these buffer loads can be default

1354

exp_* can be default

1394–1404

Default

1688–1711

Defaults

1851–1857

Defaults

jdoerfert updated this revision to Diff 465210.Oct 4 2022, 3:49 PM
jdoerfert marked 15 inline comments as done.

Address comments

jdoerfert updated this revision to Diff 465256.Oct 4 2022, 7:12 PM

Update tests

Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 7:12 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
arsenm added inline comments.Oct 4 2022, 7:43 PM
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
1582

Shouldn't be default, nosync is wrong

1649–1686

Not default, probably should not get nosync

1991

Shouldn't get nosync

1993–2012

Not sure about these ones, but maybe shouldn't get nosync

2020–2044

Also not sure about nosync for these

2457–2465

Defaults

jdoerfert updated this revision to Diff 465262.Oct 4 2022, 7:51 PM
jdoerfert marked 6 inline comments as done.

Address comments

arsenm accepted this revision.Oct 4 2022, 8:00 PM
arsenm added inline comments.
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
1226

Default

1241

Default

This revision is now accepted and ready to land.Oct 4 2022, 8:00 PM
jdoerfert marked 2 inline comments as done.Oct 5 2022, 5:23 AM
jdoerfert updated this revision to Diff 465350.Oct 5 2022, 5:25 AM

Last changes

arsenm accepted this revision.Oct 5 2022, 7:35 AM
jdoerfert updated this revision to Diff 481027.Dec 7 2022, 1:05 PM
jdoerfert edited the summary of this revision. (Show Details)

Rebase

arsenm accepted this revision.Dec 7 2022, 1:13 PM
This revision was landed with ongoing or failed builds.Dec 7 2022, 2:26 PM
This revision was automatically updated to reflect the committed changes.