Page MenuHomePhabricator

[AMDGPU] Annotate the intrinsics to be default and nocallback
ClosedPublic

Authored by jdoerfert on Oct 4 2022, 6:24 AM.

Diff Detail

Event Timeline

jdoerfert created this revision.Oct 4 2022, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 6:24 AM
jdoerfert requested review of this revision.Oct 4 2022, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 6:24 AM
jdoerfert updated this revision to Diff 464995.Oct 4 2022, 6:36 AM

update AMDGPU tests

arsenm added inline comments.Oct 4 2022, 8:11 AM
llvm/include/llvm/IR/Intrinsics.td
518

Probably best to assume this has side effects

llvm/include/llvm/IR/IntrinsicsAMDGPU.td
168

I thought WIllReturn was in the default set?

209

I'm not sure sendmsg* should be no IntrNoCallback. You can use it for device to host messaging, which I guess could trigger some visible change

273

IntrWillReturn default

arsenm added inline comments.Oct 4 2022, 8:53 AM
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
468

NoFree

496

NoFree

994

This can use Default

1080

Can be default

1103

NoFree

1176

Can be default

1242

All these buffer loads can be default

1355

exp_* can be default

1395–1405

Default

1689–1712

Defaults

1852–1858

Defaults

jdoerfert updated this revision to Diff 465210.Oct 4 2022, 3:49 PM
jdoerfert marked 15 inline comments as done.

Address comments

jdoerfert updated this revision to Diff 465256.Oct 4 2022, 7:12 PM

Update tests

Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 7:12 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
arsenm added inline comments.Oct 4 2022, 7:43 PM
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
1583

Shouldn't be default, nosync is wrong

1650–1687

Not default, probably should not get nosync

1993

Shouldn't get nosync

1995–2014

Not sure about these ones, but maybe shouldn't get nosync

2022–2046

Also not sure about nosync for these

2463–2471

Defaults

jdoerfert updated this revision to Diff 465262.Oct 4 2022, 7:51 PM
jdoerfert marked 6 inline comments as done.

Address comments

arsenm accepted this revision.Oct 4 2022, 8:00 PM
arsenm added inline comments.
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
1227

Default

1242

Default

This revision is now accepted and ready to land.Oct 4 2022, 8:00 PM
jdoerfert marked 2 inline comments as done.Oct 5 2022, 5:23 AM
jdoerfert updated this revision to Diff 465350.Oct 5 2022, 5:25 AM

Last changes

arsenm accepted this revision.Oct 5 2022, 7:35 AM
jdoerfert updated this revision to Diff 481027.Wed, Dec 7, 1:05 PM
jdoerfert edited the summary of this revision. (Show Details)

Rebase

arsenm accepted this revision.Wed, Dec 7, 1:13 PM
This revision was landed with ongoing or failed builds.Wed, Dec 7, 2:26 PM
This revision was automatically updated to reflect the committed changes.