This is an archive of the discontinued LLVM Phabricator instance.

[clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests
ClosedPublic

Authored by mgorny on Oct 3 2022, 1:05 AM.

Details

Summary

Add llvm_shlib_dir to variables used in clangd test suite, consistently
to how it is used in the test suites of clang, clang-tools-extra
and a few other components. This is necessary to ensure that
the correct shared libraries are used when building clang standalone --
otherwise, use_clang() sets LD_LIBRARY_PATH to the directory containing
the earlier system installation of clang rather than the just-built
library.

(I'd also like to backport this to 15.x)

Diff Detail

Event Timeline

mgorny created this revision.Oct 3 2022, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2022, 1:05 AM
mgorny requested review of this revision.Oct 3 2022, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2022, 1:05 AM
sammccall accepted this revision.Oct 4 2022, 12:56 PM
This revision is now accepted and ready to land.Oct 4 2022, 12:56 PM