This is an archive of the discontinued LLVM Phabricator instance.

[Clang] define __cpp_named_character_escapes
ClosedPublic

Authored by royjacobson on Sep 29 2022, 11:26 AM.

Details

Summary

Define the feature test macro for named character escapes.
I assume this was not done because it was implemented before formally accepted, right? cxx_status says the paper is implemented.

Diff Detail

Event Timeline

royjacobson created this revision.Sep 29 2022, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2022, 11:26 AM
royjacobson requested review of this revision.Sep 29 2022, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2022, 11:26 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Thanks for catching that, I missed there was a feature test macro for it.
It doesn't really make sense for it to be a feature test macro (given WG21's current policies) so I'll make raise an issue about that but I'm happy to approve the change in the meantime

cor3ntin accepted this revision.Sep 29 2022, 2:44 PM
This revision is now accepted and ready to land.Sep 29 2022, 2:44 PM

Remove literal suffix in accordance with the rest of the test

Thanks for catching that, I missed there was a feature test macro for it.
It doesn't really make sense for it to be a feature test macro (given WG21's current policies) so I'll make raise an issue about that but I'm happy to approve the change in the meantime

Then I hope we won't have to revert this in two years or something :)

But in the meantime I agree this is what users will expect so it's better to define it than not to.

This revision was landed with ongoing or failed builds.Sep 30 2022, 1:13 AM
This revision was automatically updated to reflect the committed changes.