Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
| llvm/lib/Target/LoongArch/LoongArchRegisterInfo.cpp | ||
|---|---|---|
| 138 | No it's two sentences so the suggestion is wrong. I'll add the trailing periods though (obviously the current expression can be interpreted ambiguously by non-native speakers judging from this). Thanks for the catch! | |
| llvm/lib/Target/LoongArch/LoongArchRegisterInfo.cpp | ||
|---|---|---|
| 138 | Oh, my bad :) Thanks. | |
| llvm/test/CodeGen/LoongArch/frame.ll | ||
|---|---|---|
| 42–64 | How about this IR which is simpler: define void @test_large_frame_size_2032() {
; CHECK-LABEL: test_large_frame_size_2032:
; CHECK: # %bb.0:
; CHECK-NEXT: addi.d $sp, $sp, -2032
; CHECK-NEXT: .cfi_def_cfa_offset 2032
; CHECK-NEXT: addi.d $sp, $sp, 2032
; CHECK-NEXT: ret
%1 = alloca i8, i32 2032
ret void
} | |
| llvm/test/CodeGen/LoongArch/frame.ll | ||
|---|---|---|
| 42–64 | Thanks for the suggestion; I adapted CodeGen/Generic/2010-11-04-BigByval.ll which also happened to expose the suboptimal codegen. Your version is simpler and focuses solely on the frame size handling, which I'll take. Thanks. | |
LGTM. Thanks. Others may also have a look.
| llvm/test/CodeGen/LoongArch/frame.ll | ||
|---|---|---|
| 42–64 | Thanks for the quick update. :) | |