This is an archive of the discontinued LLVM Phabricator instance.

[bazel] Respect llvm_target_list in llvm-exegesis
ClosedPublic

Authored by rupprecht on Sep 22 2022, 7:08 PM.

Details

Summary

This should hopefully fix it for the final time by using selectively build subdirectories of exegesis target libs using llvm_target_exegesis, which is derived from llvm_targets, and is the list that can vary based on the downstream user.

I verified this builds with and without Mips in the DEFAULT_TARGETS configure list, and also double checked with bazel query --output=build @llvm-project//llvm:Exegesis that lib/Mips/Target.cpp is being included if and only if Mips is in the target list.

Diff Detail

Event Timeline

rupprecht created this revision.Sep 22 2022, 7:08 PM
rupprecht requested review of this revision.Sep 22 2022, 7:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 7:08 PM
rupprecht edited the summary of this revision. (Show Details)Sep 22 2022, 7:08 PM
aeubanks accepted this revision.Sep 22 2022, 7:15 PM
This revision is now accepted and ready to land.Sep 22 2022, 7:15 PM

(I think submitting this without review would have been fine)

This revision was automatically updated to reflect the committed changes.

(I think submitting this without review would have been fine)

That's what I thought about 5b2f838db42ea190fdda147a33b5f0fcc8145689, so I figured the second attempt should have a pair of eyes :)