This is an archive of the discontinued LLVM Phabricator instance.

Differential D134505

[bazel] Remove Mips from Exegesis cc_library definition
ClosedPublic

Authored by cmtice on Sep 22 2022, 5:33 PM.

Details

Reviewers
rupprecht
aeubanks
Commits
rGc7bf9d084d03: [bazel] Remove Mips from Exegesis cc_library definition
Summary

Recent update added 'tools/llvm-exegesis/lib/Mips/*.cpp' to srcs for Exegesis cc_library. This was not needed, and in fact breaks things. This CL removes that one change.

Diff Detail

Event Timeline

cmtice created this revision.Sep 22 2022, 5:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 5:33 PM
Herald added subscribers: mstojanovic, atanasyan, arichardson, sdardis. · View Herald Transcript
cmtice requested review of this revision.Sep 22 2022, 5:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 5:33 PM
Herald added subscribers: llvm-commits, courbet. · View Herald Transcript
Harbormaster completed remote builds in B188318: Diff 462359.Sep 22 2022, 5:33 PM
cmtice added a reviewer: aeubanks.Sep 22 2022, 5:34 PM
aeubanks accepted this revision.Sep 22 2022, 5:35 PM
This revision is now accepted and ready to land.Sep 22 2022, 5:35 PM
Closed by commit rGc7bf9d084d03: [bazel] Remove Mips from Exegesis cc_library definition (authored by cmtice, committed by aeubanks). · Explain WhySep 22 2022, 5:40 PM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGc7bf9d084d03: [bazel] Remove Mips from Exegesis cc_library definition.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
llvm/
1 line

Diff 462361

utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

Show First 20 Lines • Show All 2,590 Lines • ▼ Show 20 Linescc_library(
], ],
) )
cc_library( cc_library(
name = "Exegesis", name = "Exegesis",
srcs = glob([ srcs = glob([
"tools/llvm-exegesis/lib/*.cpp", "tools/llvm-exegesis/lib/*.cpp",
"tools/llvm-exegesis/lib/AArch64/*.cpp", "tools/llvm-exegesis/lib/AArch64/*.cpp",
"tools/llvm-exegesis/lib/Mips/*.cpp",
"tools/llvm-exegesis/lib/PowerPC/*.cpp", "tools/llvm-exegesis/lib/PowerPC/*.cpp",
"tools/llvm-exegesis/lib/X86/*.cpp", "tools/llvm-exegesis/lib/X86/*.cpp",
"tools/llvm-exegesis/lib/X86/*.h", "tools/llvm-exegesis/lib/X86/*.h",
# We have to include these headers here as well as in the `hdrs` below # We have to include these headers here as well as in the `hdrs` below
# to allow the `.cpp` files to use file-relative-inclusion to find # to allow the `.cpp` files to use file-relative-inclusion to find
# them, even though consumers of this library use inclusion relative to # them, even though consumers of this library use inclusion relative to
# `tools/llvm-exegesis/lib` with the `strip_includes_prefix` of this # `tools/llvm-exegesis/lib` with the `strip_includes_prefix` of this
# library. This mixture appears to be incompatible with header modules. # library. This mixture appears to be incompatible with header modules.
▲ Show 20 Lines • Show All 1,961 Lines • Show Last 20 Lines