[BOLT] Fix (part of) dylib compatibility

[serge-sans-paille]

Summary

Non-LLVM components should not be listed as part of LLVM_LINK_COMPONENTS.

[rafauler]

Thanks for working on fixing this! The llvm-bolt-fuzzer target doesn't seem quite right, could you take a look?

bolt/tools/llvm-bolt-fuzzer/CMakeLists.txt

2

This is basically the only link from llvm-bolt-fuzzer with BOLT. We need to link it somehow. Using this diff, it fails to build for me with:

ld.lld: error: undefined symbol: opts::OutputFilename[abi:cxx11]

referenced by llvm-bolt-fuzzer.cpp:25 (/home/rafaelauler/server-llvm/llvm/llvm-project/bolt/tools/llvm-bolt-fuzzer/llvm-bolt-fuzzer.cpp:25)

tools/bolt/tools/llvm-bolt-fuzzer/CMakeFiles/llvm-bolt-fuzzer.dir/llvm-bolt-fuzzer.cpp.o:(LLVMFuzzerTestOneInput)

To test a fuzzer target, remember to add these two options to cmake:

-DLLVM_USE_SANITIZER=Address
-DLLVM_USE_SANITIZE_COVERAGE=On

[serge-sans-paille]

Fix fuzzer part

[serge-sans-paille]

@rafaelauler another try, this passes build with sanitizer off, haven't tried yet with sanitizer on.

[rafauler]

bolt/tools/llvm-bolt-fuzzer/CMakeLists.txt

10

[Amir]

Thank you for fixing that! Can you please retitle as "[BOLT]"?

[serge-sans-paille]

Address reviewers' comments

bolt/lib/Target/AArch64/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
-  BOLTCore
   MC
   Support
   AArch64Desc
   )
 
 add_llvm_library(LLVMBOLTTargetAArch64
   AArch64MCPlusBuilder.cpp
 
   DEPENDS
   AArch64CommonTableGen
   )
 
+target_link_libraries(LLVMBOLTTargetAArch64 PRIVATE LLVMBOLTCore)
+
 include_directories(
   ${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64
   ${LLVM_BINARY_DIR}/lib/Target/AArch64
   )

bolt/lib/Target/X86/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
-  BOLTCore
-  BOLTUtils
   MC
   MCDisassembler
   Support
   X86Desc
   )
 
 add_llvm_library(LLVMBOLTTargetX86
   X86MCPlusBuilder.cpp
   X86MCSymbolizer.cpp
 
   DEPENDS
   X86CommonTableGen
   )
 
+target_link_libraries(LLVMBOLTTargetX86 PRIVATE LLVMBOLTCore LLVMBOLTUtils)
+
 include_directories(
   ${LLVM_MAIN_SRC_DIR}/lib/Target/X86
   ${LLVM_BINARY_DIR}/lib/Target/X86
   )

bolt/tools/llvm-bolt-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
-  BOLTRewrite
   ${LLVM_TARGETS_TO_BUILD}
   )
 
 add_llvm_fuzzer(llvm-bolt-fuzzer
   llvm-bolt-fuzzer.cpp
   )
+
+if (TARGET llvm-bolt-fuzzer)
+    target_link_libraries(llvm-bolt-fuzzer PRIVATE LLVMBOLTRewrite)
+endif()