This is an archive of the discontinued LLVM Phabricator instance.

Differential D134077

[RISCV] Support -mno-implicit-float.
ClosedPublic

Authored by craig.topper on Sep 16 2022, 2:20 PM.

Details

Reviewers
asb
reames
compnerd
rui.zhang
Commits
rG549231d38e10: [RISCV] Support -mno-implicit-float.
Summary

This can be used to disable vectorization and memcpy/memset
expansion for things like OS kernels. It also disables implicit
uses of scalar FP, but I don't know if we have any of those for
RISC-V.

NOTE: Without this patch you can still do -Xclang -no-implicit-float

Diff Detail

Event Timeline

craig.topper created this revision.Sep 16 2022, 2:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 2:20 PM
Herald added subscribers: sunshaoce, VincentWu, StephenFan and 14 others. · View Herald Transcript
craig.topper requested review of this revision.Sep 16 2022, 2:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 2:20 PM
Herald added subscribers: cfe-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B187242: Diff 460897.Sep 16 2022, 3:53 PM
rui.zhang accepted this revision.Sep 16 2022, 9:43 PM

Thanks for fixing it.

This revision is now accepted and ready to land.Sep 16 2022, 9:43 PM
craig.topper edited the summary of this revision. (Show Details)Sep 16 2022, 9:58 PM
Closed by commit rG549231d38e10: [RISCV] Support -mno-implicit-float. (authored by craig.topper). · Explain WhySep 20 2022, 1:32 PM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rG549231d38e10: [RISCV] Support -mno-implicit-float..

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
4 lines
test/
Driver/
6 lines

Diff 461682

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,188 Lines • ▼ Show 20 Linesvoid Clang::AddRISCVTargetArgs(const ArgList &Args,
const llvm::Triple &Triple = getToolChain().getTriple(); const llvm::Triple &Triple = getToolChain().getTriple();
StringRef ABIName = riscv::getRISCVABI(Args, Triple); StringRef ABIName = riscv::getRISCVABI(Args, Triple);
CmdArgs.push_back("-target-abi"); CmdArgs.push_back("-target-abi");
CmdArgs.push_back(ABIName.data()); CmdArgs.push_back(ABIName.data());
SetRISCVSmallDataLimit(getToolChain(), Args, CmdArgs); SetRISCVSmallDataLimit(getToolChain(), Args, CmdArgs);
if (!Args.hasFlag(options::OPT_mimplicit_float,
options::OPT_mno_implicit_float, true))
CmdArgs.push_back("-no-implicit-float");
if (const Arg *A = Args.getLastArg(options::OPT_mtune_EQ)) { if (const Arg *A = Args.getLastArg(options::OPT_mtune_EQ)) {
CmdArgs.push_back("-tune-cpu"); CmdArgs.push_back("-tune-cpu");
CmdArgs.push_back(A->getValue()); CmdArgs.push_back(A->getValue());
} }
} }
void Clang::AddSparcTargetArgs(const ArgList &Args, void Clang::AddSparcTargetArgs(const ArgList &Args,
ArgStringList &CmdArgs) const { ArgStringList &CmdArgs) const {
▲ Show 20 Lines • Show All 6,294 Lines • Show Last 20 Lines

clang/test/Driver/flags.c

Show All 21 Lines
// RUN: %clang -target armv7-apple-darwin10 -### -S -mno-implicit-float %s 2>&1 | FileCheck -check-prefix=TEST7 %s // RUN: %clang -target armv7-apple-darwin10 -### -S -mno-implicit-float %s 2>&1 | FileCheck -check-prefix=TEST7 %s
// TEST7: "-no-implicit-float" // TEST7: "-no-implicit-float"
// RUN: %clang -target armv7-apple-darwin10 -### -S -mno-implicit-float -mimplicit-float %s 2>&1 | FileCheck -check-prefix=TEST8 %s // RUN: %clang -target armv7-apple-darwin10 -### -S -mno-implicit-float -mimplicit-float %s 2>&1 | FileCheck -check-prefix=TEST8 %s
// TEST8-NOT: "-no-implicit-float" // TEST8-NOT: "-no-implicit-float"
// RUN: %clang -target x86_64-linux-gnu -### -c -fclang-abi-compat=3.2 %s 2>&1 | FileCheck -check-prefix=TEST9 %s // RUN: %clang -target x86_64-linux-gnu -### -c -fclang-abi-compat=3.2 %s 2>&1 | FileCheck -check-prefix=TEST9 %s
// TEST9: "-fclang-abi-compat=3.2" // TEST9: "-fclang-abi-compat=3.2"
//
// RUN: %clang -target riscv32 -### -S -mno-implicit-float %s 2>&1 | FileCheck -check-prefix=TEST10 %s
// TEST10: "-no-implicit-float"
//
// RUN: %clang -target riscv64 -### -S -mno-implicit-float %s 2>&1 | FileCheck -check-prefix=TEST11 %s
// TEST11: "-no-implicit-float"