This is an archive of the discontinued LLVM Phabricator instance.

Differential D134034

[test] Use host platform specific error message substitution
ClosedPublic

Authored by abhina.sreeskantharajan on Sep 16 2022, 6:15 AM.

Details

Reviewers
steven.zhang
fanbo-meng
muiez
Kai
zibi
Everybody0523
Commits
rGce193431141d: [test] Use host platform specific error message substitution
Summary

This patch modifies the testcase to use error substitution so it will pass on all platforms.

Diff Detail

Unit TestsFailed

TimeTest
160 msx64 debian > LLVM.tools/llvm-dwp/X86::diagnose_missing_dwos.test
60,040 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

abhina.sreeskantharajan created this revision.Sep 16 2022, 6:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 6:15 AM
abhina.sreeskantharajan requested review of this revision.Sep 16 2022, 6:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 6:15 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
abhina.sreeskantharajan retitled this revision from This patch modifies the testcase to use error substitution so it will pass on all platforms. to [test] Use host platform specific error message substitution.Sep 16 2022, 6:22 AM
abhina.sreeskantharajan edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B187119: Diff 460719.Sep 16 2022, 7:25 AM
abhina.sreeskantharajan updated this revision to Diff 460754.Sep 16 2022, 7:38 AM

Forgot to add DMSG to one more line

abhina.sreeskantharajan added reviewers: steven.zhang, fanbo-meng, muiez, Kai, zibi, • neumannh.Sep 16 2022, 7:41 AM
abhina.sreeskantharajan edited reviewers, added: Everybody0523; removed: • neumannh.
abhina.sreeskantharajan updated this revision to Diff 460761.Sep 16 2022, 7:50 AM

Add some more tests

Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 7:50 AM
Herald added subscribers: cfe-commits, ormris. · View Herald Transcript
fanbo-meng accepted this revision.Sep 16 2022, 7:52 AM

LGTM

This revision is now accepted and ready to land.Sep 16 2022, 7:52 AM
zibi accepted this revision.Sep 16 2022, 8:33 AM

LGTM

Harbormaster completed remote builds in B187151: Diff 460761.Sep 16 2022, 8:51 AM
abhina.sreeskantharajan updated this revision to Diff 460828.Sep 16 2022, 11:20 AM

Move subsitution outside regex

Harbormaster completed remote builds in B187189: Diff 460828.Sep 16 2022, 11:59 AM
Closed by commit rGce193431141d: [test] Use host platform specific error message substitution (authored by abhina.sreeskantharajan). · Explain WhySep 16 2022, 12:14 PM
This revision was automatically updated to reflect the committed changes.
abhina.sreeskantharajan added a commit: rGce193431141d: [test] Use host platform specific error message substitution.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-dwp/
X86/
10 lines
llvm-tapi-diff/
4 lines

Diff 460719

llvm/test/tools/llvm-dwp/X86/diagnose_missing_dwos.test

RUN: rm -rf %t RUN: rm -rf %t
RUN: mkdir %t RUN: mkdir %t
RUN: cd %t RUN: cd %t
RUN: cp %p/../Inputs/dwos_list_from_exec/b.dwo b.dwo RUN: cp %p/../Inputs/dwos_list_from_exec/b.dwo b.dwo
RUN: cp %p/../Inputs/dwos_list_from_exec/main main RUN: cp %p/../Inputs/dwos_list_from_exec/main main
RUN: not llvm-dwp -e binary -o /dev/null 2>&1 | FileCheck %s --check-prefix=CHECK-BIN RUN: not llvm-dwp -e binary -o /dev/null 2>&1 | FileCheck -DMSG=%errc_ENOENT %s --check-prefix=CHECK-BIN
RUN: not llvm-dwp -e main -o /dev/null 2>&1 | FileCheck %s --check-prefix=CHECK-1ST-DWO RUN: not llvm-dwp -e main -o /dev/null 2>&1 | FileCheck -DMSG=%errc_ENOENT %s --check-prefix=CHECK-1ST-DWO
RUN: cp %p/../Inputs/dwos_list_from_exec/a.dwo a.dwo RUN: cp %p/../Inputs/dwos_list_from_exec/a.dwo a.dwo
RUN: rm b.dwo RUN: rm b.dwo
RUN: not llvm-dwp -e main -o /dev/null 2>&1 | FileCheck %s --check-prefix=CHECK-2ND-DWO RUN: not llvm-dwp -e main -o /dev/null 2>&1 | FileCheck %s --check-prefix=CHECK-2ND-DWO
Build commands for the test binaries: Build commands for the test binaries:
clang++ -Xclang -fdebug-compilation-dir -Xclang "./" -g -O0 -gsplit-dwarf a.cpp b.cpp -o main clang++ -Xclang -fdebug-compilation-dir -Xclang "./" -g -O0 -gsplit-dwarf a.cpp b.cpp -o main
sources: sources:
a.cpp: a.cpp:
void a() {} void a() {}
b.cpp: b.cpp:
void b() {} void b() {}
int main() { int main() {
return 0; return 0;
} }
CHECK-BIN: error: 'binary': {{[Nn]}}o such file or directory CHECK-BIN: error: 'binary': [[MSG]]
CHECK-1ST-DWO: error: './a.dwo': {{[Nn]}}o such file or directory CHECK-1ST-DWO: error: './a.dwo': [[MSG]]
CHECK-2ND-DWO: error: './b.dwo': {{[Nn]}}o such file or directory CHECK-2ND-DWO: error: './b.dwo': [[MSG]]

llvm/test/tools/llvm-tapi-diff/misspelled-tbd.test

; RUN: not llvm-tapi-diff %S/Inputs/v4A.tbd %S/Inputs/v4.tbd 2>&1 | FileCheck %s ; RUN: not llvm-tapi-diff %S/Inputs/v4A.tbd %S/Inputs/v4.tbd 2>&1 | FileCheck -DMSG=%errc_ENOENT %s
; CHECK: error: {{.*}}v4.tbd' {{[Nn]}}o such file or directory ; CHECK: error: {{.*}}v4.tbd' [[MSG]]