This is an archive of the discontinued LLVM Phabricator instance.

[mlir] make memref.subview produce strided layout
ClosedPublic

Authored by ftynse on Sep 15 2022, 5:44 AM.

Details

Summary

Memref subview operation has been initially designed to work on memrefs with
strided layouts only and has never supported anything else. Port it to use the
recently added StridedLayoutAttr instead of extracting the strided from
implicitly from affine maps.

Diff Detail

Event Timeline

ftynse created this revision.Sep 15 2022, 5:44 AM
ftynse requested review of this revision.Sep 15 2022, 5:44 AM
Herald added a project: Restricted Project. · View Herald Transcript
nicolasvasilache accepted this revision.Sep 15 2022, 2:22 PM

Nice!

mlir/test/Dialect/Bufferization/Transforms/one-shot-module-bufferize-out-params.mlir
101

it's also nice that we don't to chase affine maps around at the top of the file.

This revision is now accepted and ready to land.Sep 15 2022, 2:22 PM
This revision was landed with ongoing or failed builds.Sep 16 2022, 1:57 AM
This revision was automatically updated to reflect the committed changes.