The old device runtime had a "simplified" version that prevented many of
the runtime features from being initialized. The old device runtime was
deleted in LLVM 14 and is no longer in use. Selectively deactivating
features is now done using specific flags rather than the old technique.
This patch simply removes the extra logic required for handling the old
simple runtime scheme.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This is a good idea. Thanks Joseph.
Other than the two comments I made, I think this should be accepted.
Jose
clang/include/clang/Driver/Options.td | ||
---|---|---|
2564–2565 | Why not remove these? Are they used somewhere else? | |
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp | ||
77–84 | What if we combine these two and just leave one that receives two modes. I am really confused by this code. Is there something I am missing here? |
clang/include/clang/Driver/Options.td | ||
---|---|---|
2564–2565 | We usually don't remove driver arguments between releases as this could cause existing applications to stop compiling. Leaving them here will cause Clang to continue compiling but emit an unused flag warning. | |
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp | ||
77–84 | Just me being lazy, I'll combine it into a single one. |
clang/include/clang/Driver/Options.td | ||
---|---|---|
2564–2565 | Will that generate a warning saying this flag has no use? |
Removing the flag as per Johanness' suggestion. This will break old build
configruations using this flag, but it should be easy to work around in the
worst case.
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp | ||
---|---|---|
1048 | So, follow up for this? |
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp | ||
---|---|---|
1048 | Yes, it changes a lot of tests so I wanted to make it a separate patch. |
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp | ||
---|---|---|
1048 | It's mostly meaningless as I'll remove it later anyway. I figured changing it to true was closer to what this change means as we always use the full runtime. |
Why not remove these? Are they used somewhere else?