Page MenuHomePhabricator

[flang][driver]Fix broken flang-new mlir test
ClosedPublic

Authored by Leporacanthicus on Sep 13 2022, 10:59 AM.

Details

Summary

The test was added as a .mlir file, and this extension is not
in the lit.cfg.py, so it was never run. When running it, the
file would produce an error, as semicolon is not an MLIR comment.

This adds the extension and fixes the comment start by using C++
style comments.

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Leporacanthicus requested review of this revision.Sep 13 2022, 10:59 AM
awarzynski accepted this revision.Sep 13 2022, 11:05 AM

Thanks Mats!

This revision is now accepted and ready to land.Sep 13 2022, 11:05 AM
awarzynski added inline comments.Sep 13 2022, 11:06 AM
flang/test/lit.cfg.py
30–31

[nit] Perhaps .mlir and .fir should be next to each other?

This revision was automatically updated to reflect the committed changes.