Differential D133714

[ADT] Introduce LazyAtomicPointer
AcceptedPublic
Actions

Authored by steven_wu on Sep 12 2022, 10:41 AM.

Tags

Subscribers

Details

Reviewers

rnk
dblaikie
dexonsmith
benlangmuir

Summary

LazyAtomicPointer is a lock-free pointer that can coordinate concurrent
writes to a pointer using a generator.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,060 ms	x64 debian > libFuzzer.libFuzzer::fuzzer-leak.test Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LeakTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/fuzzer-leak.test.tmp-LeakTest
	60,070 ms	x64 debian > libFuzzer.libFuzzer::minimize_crash.test Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/NullDerefTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/minimize_crash.test.tmp-NullDerefTest
	60,080 ms	x64 debian > libFuzzer.libFuzzer::value-profile-load.test Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LoadTest.cpp -fsanitize-coverage=trace-gep -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/value-profile-load.test.tmp-LoadTest
	60,160 ms	x64 debian > libFuzzer.libFuzzer::value-profile-switch.test Script: -- : 'RUN: at line 5'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/SwitchTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/value-profile-switch.test.tmp-SwitchTest

Event Timeline

steven_wu created this revision.Sep 12 2022, 10:41 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 10:41 AM

Herald added subscribers: ributzka, mgorny. · View Herald Transcript

steven_wu requested review of this revision.Sep 12 2022, 10:41 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 10:41 AM

steven_wu added a child revision: D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.Sep 12 2022, 10:43 AM

Harbormaster completed remote builds in B186194: Diff 459512.Sep 12 2022, 11:36 AM

akyrtzi added a subscriber: akyrtzi.Sep 12 2022, 12:54 PM

benlangmuir accepted this revision.Sep 15 2022, 12:05 PM

benlangmuir added inline comments.

llvm/include/llvm/ADT/LazyAtomicPointer.h
2	Looks like "h " got dropped.

This revision is now accepted and ready to land.Sep 15 2022, 12:05 PM

Fix the busy state test on windows by avoid lock ownership issues

Address review feedback

steven_wu marked an inline comment as done.Sep 15 2022, 3:57 PM

Harbormaster completed remote builds in B186956: Diff 460528.Sep 15 2022, 5:04 PM

Use conditional variable to coordinate to avoid spinning on atomics

steven_wu added a child revision: D133715: [ADT] Add TrieRawHashMap.Sep 19 2022, 3:21 PM

steven_wu removed a child revision: D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.

Harbormaster completed remote builds in B187618: Diff 461387.Sep 19 2022, 6:11 PM

Minor format and test update

Harbormaster completed remote builds in B206161: Diff 486933.Jan 6 2023, 11:50 AM

avl added a child revision: D132548: [WIP][ADT] Utility for comparision of hashtables implementation..Feb 26 2023, 7:45 AM

Revision Contents
Changeset List

Path

Size

llvm/

include/

llvm/

ADT/

LazyAtomicPointer.h

166 lines

unittests/

ADT/

1 line

LazyAtomicPointerTest.cpp

82 lines

Diff 486933

llvm/include/llvm/ADT/LazyAtomicPointer.h

Loading...

llvm/unittests/ADT/CMakeLists.txt

Loading...

llvm/unittests/ADT/LazyAtomicPointerTest.cpp

Loading...