Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D133714

[ADT] Introduce LazyAtomicPointer
AcceptedPublic
Actions

Authored by steven_wu on Sep 12 2022, 10:41 AM.

Details

Reviewers
rnk
dblaikie
dexonsmith
benlangmuir
Summary

LazyAtomicPointer is a lock-free pointer that can coordinate concurrent
writes to a pointer using a generator.

Diff Detail

Event Timeline

steven_wu created this revision.Sep 12 2022, 10:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 10:41 AM
Herald added subscribers: ributzka, mgorny. · View Herald Transcript
steven_wu requested review of this revision.Sep 12 2022, 10:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 10:41 AM
steven_wu added a child revision: D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.Sep 12 2022, 10:43 AM
Harbormaster completed remote builds in B186194: Diff 459512.Sep 12 2022, 11:36 AM
akyrtzi added a subscriber: akyrtzi.Sep 12 2022, 12:54 PM
benlangmuir accepted this revision.Sep 15 2022, 12:05 PM
benlangmuir added inline comments.
llvm/include/llvm/ADT/LazyAtomicPointer.h
1

Looks like "h " got dropped.

This revision is now accepted and ready to land.Sep 15 2022, 12:05 PM
steven_wu updated this revision to Diff 460526.Sep 15 2022, 3:55 PM

Fix the busy state test on windows by avoid lock ownership issues

steven_wu updated this revision to Diff 460528.Sep 15 2022, 3:57 PM

Address review feedback

steven_wu marked an inline comment as done.Sep 15 2022, 3:57 PM
Harbormaster completed remote builds in B186956: Diff 460528.Sep 15 2022, 5:04 PM
steven_wu updated this revision to Diff 461387.Sep 19 2022, 3:20 PM

Use conditional variable to coordinate to avoid spinning on atomics

steven_wu added a child revision: D133715: [ADT] Add TrieRawHashMap.Sep 19 2022, 3:21 PM
steven_wu removed a child revision: D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.
Harbormaster completed remote builds in B187618: Diff 461387.Sep 19 2022, 6:11 PM
steven_wu updated this revision to Diff 486933.Jan 6 2023, 10:43 AM

Minor format and test update

Harbormaster completed remote builds in B206161: Diff 486933.Jan 6 2023, 11:50 AM
avl added a child revision: D132548: [WIP][ADT] Utility for comparision of hashtables implementation..Feb 26 2023, 7:45 AM
JamesWidman added a subscriber: JamesWidman.Tue, Aug 29, 4:08 PM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
ADT/
166 lines
unittests/
ADT/
1 line
70 lines

Diff 459512

View Options

llvm/include/llvm/ADT/LazyAtomicPointer.h

Loading...
View Options

llvm/unittests/ADT/CMakeLists.txt

Loading...
View Options

llvm/unittests/ADT/LazyAtomicPointerTest.cpp

Loading...