Page MenuHomePhabricator

benlangmuir (Ben Langmuir)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2013, 8:31 AM (491 w, 5 h)

Recent Activity

Fri, Jul 1

benlangmuir accepted D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback.
Fri, Jul 1, 2:18 PM · Restricted Project, Restricted Project, Restricted Project
benlangmuir added a comment to D128872: [compiler-rt] Enable the new ABI of `_Float16` for Darwin on X86.

I checked this on my arm64 mac:

  • These test are already failing on main branch due to the mismatch with -DCOMPILER_RT_HAS_FLOAT16
  • They are still failing with this patch (due to conditionalizing the macro definition on x86)
  • If I remove the conditional and always define COMPILER_RT_HAS_FLOAT16 when building the builtins for darwin, the tests pass for me. I don't know which ABI we want here for arm[64], but it confirms we need to be consistent about the conditional define.
Fri, Jul 1, 11:50 AM · Restricted Project, Restricted Project

Thu, Jun 30

benlangmuir added inline comments to D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback.
Thu, Jun 30, 3:37 PM · Restricted Project, Restricted Project, Restricted Project
benlangmuir added inline comments to D128872: [compiler-rt] Enable the new ABI of `_Float16` for Darwin on X86.
Thu, Jun 30, 9:11 AM · Restricted Project, Restricted Project

Wed, Jun 29

benlangmuir accepted D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing.
Wed, Jun 29, 3:41 PM · Restricted Project, Restricted Project
benlangmuir added inline comments to D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing.
Wed, Jun 29, 3:05 PM · Restricted Project, Restricted Project

Tue, Jun 28

benlangmuir added a comment to D128571: [X86] Support `_Float16` on SSE2 and up.

Reverted in eab2a06f0fde due to the Darwin test failures.

Tue, Jun 28, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
benlangmuir committed rGeab2a06f0fde: Revert "Reland "[X86] Support `_Float16` on SSE2 and up"" (authored by benlangmuir).
Revert "Reland "[X86] Support `_Float16` on SSE2 and up""
Tue, Jun 28, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
benlangmuir added a reverting change for rG527ef8ca981e: Reland "[X86] Support `_Float16` on SSE2 and up": rGeab2a06f0fde: Revert "Reland "[X86] Support `_Float16` on SSE2 and up"".
Tue, Jun 28, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
benlangmuir added a reverting change for D128571: [X86] Support `_Float16` on SSE2 and up: rGeab2a06f0fde: Revert "Reland "[X86] Support `_Float16` on SSE2 and up"".
Tue, Jun 28, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
benlangmuir added a comment to D128571: [X86] Support `_Float16` on SSE2 and up.

This broke some compiler-rt tests on Darwin:
https://green.lab.llvm.org/green/job/clang-stage1-RA/29920/

Tue, Jun 28, 10:27 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 23

benlangmuir requested review of D128475: Break module dependency llvm-tblgen -> LLVM_MC.
Thu, Jun 23, 3:41 PM · Restricted Project, Restricted Project

Fri, Jun 17

benlangmuir committed rG4a3a9a5fa0b2: [clang][deps] Sort submodules when calculating dependencies (authored by benlangmuir).
[clang][deps] Sort submodules when calculating dependencies
Fri, Jun 17, 8:10 AM · Restricted Project, Restricted Project
benlangmuir closed D128008: [clang][deps] Sort submodules when calculating dependencies.
Fri, Jun 17, 8:10 AM · Restricted Project, Restricted Project

Thu, Jun 16

benlangmuir requested review of D128008: [clang][deps] Sort submodules when calculating dependencies.
Thu, Jun 16, 2:37 PM · Restricted Project, Restricted Project

Wed, Jun 15

benlangmuir committed rG509223da6114: [clang][deps] Further canonicalize implicit modules options in dep scan (authored by benlangmuir).
[clang][deps] Further canonicalize implicit modules options in dep scan
Wed, Jun 15, 1:30 PM · Restricted Project, Restricted Project
benlangmuir closed D127883: [clang][deps] Further canonicalize implicit modules options in dep scan.
Wed, Jun 15, 1:30 PM · Restricted Project, Restricted Project
benlangmuir requested review of D127883: [clang][deps] Further canonicalize implicit modules options in dep scan.
Wed, Jun 15, 11:02 AM · Restricted Project, Restricted Project

Mon, Jun 13

benlangmuir accepted D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.

Couple more minor things, but basically LGTM.

Mon, Jun 13, 2:09 PM · Restricted Project, Restricted Project
benlangmuir added inline comments to D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.
Mon, Jun 13, 10:08 AM · Restricted Project, Restricted Project

Wed, Jun 8

benlangmuir committed rG835fcf2aa512: [clang][deps] Make order of module dependencies deterministic (authored by benlangmuir).
[clang][deps] Make order of module dependencies deterministic
Wed, Jun 8, 11:11 AM · Restricted Project, Restricted Project
benlangmuir committed rG7a72dca74a27: [clang][deps] Set -disable-free for module compilations (authored by benlangmuir).
[clang][deps] Set -disable-free for module compilations
Wed, Jun 8, 11:11 AM · Restricted Project, Restricted Project
benlangmuir closed D127243: [clang][deps] Make order of module dependencies deterministic.
Wed, Jun 8, 11:11 AM · Restricted Project, Restricted Project
benlangmuir closed D127229: [clang][deps] Set -disable-free for module compilations.
Wed, Jun 8, 11:11 AM · Restricted Project, Restricted Project
benlangmuir added inline comments to D127229: [clang][deps] Set -disable-free for module compilations.
Wed, Jun 8, 10:31 AM · Restricted Project, Restricted Project
benlangmuir updated the diff for D127243: [clang][deps] Make order of module dependencies deterministic.

Removed use of std::unique_ptr in DependencyScanningTool.cpp, per review feedback.

Wed, Jun 8, 10:15 AM · Restricted Project, Restricted Project
benlangmuir added inline comments to D127243: [clang][deps] Make order of module dependencies deterministic.
Wed, Jun 8, 8:38 AM · Restricted Project, Restricted Project

Tue, Jun 7

benlangmuir updated the diff for D127229: [clang][deps] Set -disable-free for module compilations.

Attempt to fix Windows path issue in test.

Tue, Jun 7, 12:36 PM · Restricted Project, Restricted Project
benlangmuir requested review of D127243: [clang][deps] Make order of module dependencies deterministic.
Tue, Jun 7, 12:28 PM · Restricted Project, Restricted Project
benlangmuir requested review of D127229: [clang][deps] Set -disable-free for module compilations.
Tue, Jun 7, 10:13 AM · Restricted Project, Restricted Project

May 12 2022

benlangmuir added inline comments to D121733: Clean pathnames in FileManager..
May 12 2022, 10:05 AM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

benlangmuir added inline comments to D117173: [ORC-RT] Hook objc's class_getImageName for JITDylibs.
Apr 29 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

benlangmuir accepted D124635: Frontend: Delete output streams before closing CompilerInstance outputs.
Apr 28 2022, 4:23 PM · Restricted Project, Restricted Project
benlangmuir added a comment to D124635: Frontend: Delete output streams before closing CompilerInstance outputs.

LGTM, although I made a suggestion about the spelling.

Apr 28 2022, 4:23 PM · Restricted Project, Restricted Project

Apr 22 2022

benlangmuir accepted D124288: [Index] Remove reference to `UnresolvedUsingIfExists`.

Minor suggestion for the test case, but otherwise LGTM.

Apr 22 2022, 2:49 PM · Restricted Project, Restricted Project

Apr 6 2022

benlangmuir accepted D123197: Remove a few effectively-unused FileEntry APIs. NFC.
Apr 6 2022, 3:39 PM · Restricted Project, Restricted Project
benlangmuir added inline comments to D123197: Remove a few effectively-unused FileEntry APIs. NFC.
Apr 6 2022, 11:46 AM · Restricted Project, Restricted Project
benlangmuir added inline comments to D123197: Remove a few effectively-unused FileEntry APIs. NFC.
Apr 6 2022, 11:44 AM · Restricted Project, Restricted Project

Apr 5 2022

benlangmuir accepted D123104: [Modules] Use looked-up filename when looking for module maps.
Apr 5 2022, 10:56 AM · Restricted Project, Restricted Project

Jan 25 2022

benlangmuir committed rG0e5ea403e8de: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT (authored by benlangmuir).
Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT
Jan 25 2022, 8:28 AM
benlangmuir closed D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT.
Jan 25 2022, 8:28 AM · Restricted Project

Jan 24 2022

benlangmuir added a comment to D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT.

Does check-orc-rt need to be added to COMPILER_RT_TEST_SUITES too? I guess not, otherwise we wouldn't have seen this missing dependency in the first place?

Jan 24 2022, 4:53 PM · Restricted Project
benlangmuir requested review of D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT.
Jan 24 2022, 4:09 PM · Restricted Project

Jan 18 2022

benlangmuir committed rGfa40c53960e2: [llvm-jitlink] Prevent dead-stripping of test callback (authored by benlangmuir).
[llvm-jitlink] Prevent dead-stripping of test callback
Jan 18 2022, 3:58 PM
benlangmuir closed D117609: [llvm-jitlink] Prevent dead-stripping of test callback.
Jan 18 2022, 3:58 PM · Restricted Project
benlangmuir requested review of D117609: [llvm-jitlink] Prevent dead-stripping of test callback.
Jan 18 2022, 2:29 PM · Restricted Project

Jan 14 2022

benlangmuir committed rGca2353ce5a77: Teach llvm-jitlink to support archives in inputs files and -load_hidden (authored by benlangmuir).
Teach llvm-jitlink to support archives in inputs files and -load_hidden
Jan 14 2022, 4:28 PM
benlangmuir closed D117360: Teach llvm-jitlink to support archives in inputs files and -load_hidden.
Jan 14 2022, 4:28 PM · Restricted Project
benlangmuir requested review of D117360: Teach llvm-jitlink to support archives in inputs files and -load_hidden.
Jan 14 2022, 1:59 PM · Restricted Project
benlangmuir added a comment to D116174: [clang] support relative roots to vfs overlays.

Make sure the test failure gets fixed, but otherwise LGTM.

x64 debian > LLVM-Unit.Support/_/SupportTests::VFSFromYAMLTest.RelativePaths

Jan 14 2022, 9:55 AM · Restricted Project, Restricted Project
benlangmuir accepted D116174: [clang] support relative roots to vfs overlays.
Jan 14 2022, 9:54 AM · Restricted Project, Restricted Project

Jan 13 2022

benlangmuir added a comment to D116174: [clang] support relative roots to vfs overlays.

Each VFS may have its own working directory, so it could be surprising if we use the OS working directory instead of that. This is complicated by the fact the VFS working directory may not be set yet during parsing the yaml (I haven't checked). I'm not really sure what to recommend here. If we do change this, we should document the new behaviour in the doc comment for RedirectingFileSystem though.

Jan 13 2022, 3:39 PM · Restricted Project, Restricted Project
benlangmuir added a comment to D116659: [llvm][clang][vfs] NFC: Simplify directory iteration.

I don't know, I'm a bit skeptical we want to make it so easy to ignore errors so easily. I'd rather require clients to explicitly ignore the error.

Jan 13 2022, 1:39 PM · Restricted Project, Restricted Project

Jan 12 2022

benlangmuir added inline comments to D117173: [ORC-RT] Hook objc's class_getImageName for JITDylibs.
Jan 12 2022, 4:48 PM · Restricted Project, Restricted Project, Restricted Project
benlangmuir requested review of D117173: [ORC-RT] Hook objc's class_getImageName for JITDylibs.
Jan 12 2022, 4:42 PM · Restricted Project, Restricted Project, Restricted Project

Jan 4 2022

benlangmuir added a comment to D116139: [ORC-RT] Add debug logging macros..

Handling "" as enabling all logging is a bit strange to me -- what was the reasoning for that? LGTM other than than the return value from initializeDebug that I mentioned.

Jan 4 2022, 10:27 AM · Restricted Project

Dec 23 2021

benlangmuir added inline comments to D116139: [ORC-RT] Add debug logging macros..
Dec 23 2021, 11:43 AM · Restricted Project

Dec 22 2021

benlangmuir added inline comments to D116139: [ORC-RT] Add debug logging macros..
Dec 22 2021, 10:04 AM · Restricted Project
benlangmuir added inline comments to D116139: [ORC-RT] Add debug logging macros..
Dec 22 2021, 10:00 AM · Restricted Project

Dec 16 2021

benlangmuir committed rGec37e0bbafab: Re-apply "Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib" (authored by benlangmuir).
Re-apply "Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib"
Dec 16 2021, 9:26 AM
benlangmuir closed D115825: Re-apply "Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib".
Dec 16 2021, 9:25 AM · Restricted Project, Restricted Project
benlangmuir updated the diff for D115825: Re-apply "Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib".

Updated to enable the visibility macro when using BUILD_SHARED_LIBS and remove the MLIR-specific change, per review.

Dec 16 2021, 8:25 AM · Restricted Project, Restricted Project

Dec 15 2021

benlangmuir added inline comments to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.
Dec 15 2021, 1:24 PM · Restricted Project
benlangmuir added inline comments to D115825: Re-apply "Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib".
Dec 15 2021, 12:57 PM · Restricted Project, Restricted Project
benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

Never mind, I got it working on Linux. BUILD_SHARED_LIBS of MLIR doesn't seem to work correctly on macOS. New patch with a fix: https://reviews.llvm.org/D115825

Dec 15 2021, 12:53 PM · Restricted Project
benlangmuir requested review of D115825: Re-apply "Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib".
Dec 15 2021, 12:52 PM · Restricted Project, Restricted Project
benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

@mehdi_amini x86_64 macOS

Dec 15 2021, 9:11 AM · Restricted Project

Dec 14 2021

benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

@mehdi_amini I'm seeing the same failure output in the llvm.c test even with my changes reverted and a clean build. Any idea what I might be missing? I am building with the following arguments -- they're about as close as I could get to that bot without having CUDA.

Dec 14 2021, 5:52 PM · Restricted Project
benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

@mehdi_amini thanks!

Dec 14 2021, 10:26 AM · Restricted Project
benlangmuir committed rG71e97ad35b2a: Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib (authored by benlangmuir).
Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib
Dec 14 2021, 9:59 AM
benlangmuir closed D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.
Dec 14 2021, 9:59 AM · Restricted Project

Dec 10 2021

benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

Since the new approach is no longer "opt-in", I tested:

  • Default build (static, LLVMInitialize* is external)
  • -DCMAKE_CXX_VISIBILITY_PRESET=hidden (static, LLVMInitialize* is hidden -- this is the new thing)
  • -DBUILD_SHARED_LIBS=YES (dynamic, LLVMInitialize* is external due to not overriding visibility)
  • -LLVM_LINK_LLVM_DYLIB=YES (dynamic, LLVMInitialize* is external due to LLVM_EXTERNAL_VISIBILITY)
Dec 10 2021, 3:38 PM · Restricted Project
benlangmuir updated the diff for D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

Updated to set LLVM_EXTERNAL_VISIBILITY only when building the LLVM dylib.

Dec 10 2021, 3:34 PM · Restricted Project

Dec 9 2021

benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

I don't have a horse in this race since this is LLVM and not libc++, however from a user perspective, it would feel more ergonomic to have a single setting like LLVM_VISIBILITY=normal|hidden. Or something like LLVM_HIDDEN_VISIBILITY=ON (by default it's OFF, which means default visibility is used).

Heck, thinking about it, why does LLVM even override what's decided by CMAKE_CXX_VISIBILITY_PRESET? It seems to me that:

  • LLVM_LIBRARY_VISIBILITY should always be hidden, and
  • LLVM_EXTERNAL_VISIBILITY should be whatever CMAKE_CXX_VISIBILITY_PRESET says
Dec 9 2021, 2:43 PM · Restricted Project
benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

Ping, does anyone have any feedback on this?

Dec 9 2021, 1:52 PM · Restricted Project

Nov 19 2021

benlangmuir closed D114210: [ORC] Fix materialization of weak local symbols.

4c94760f360bd4e24519a61bea3bde0413aaf78a

Nov 19 2021, 7:27 AM · Restricted Project
benlangmuir committed rG4c94760f360b: [ORC] Fix materialization of weak local symbols (authored by benlangmuir).
[ORC] Fix materialization of weak local symbols
Nov 19 2021, 7:26 AM

Nov 18 2021

benlangmuir requested review of D114210: [ORC] Fix materialization of weak local symbols.
Nov 18 2021, 4:55 PM · Restricted Project

Nov 17 2021

benlangmuir committed rG5273773580f6: [JITLink] Allow duplicate symbol names for locals (authored by benlangmuir).
[JITLink] Allow duplicate symbol names for locals
Nov 17 2021, 9:32 AM
benlangmuir closed D114042: [JITLink] Allow duplicate symbol names for locals.
Nov 17 2021, 9:32 AM · Restricted Project

Nov 16 2021

benlangmuir requested review of D114042: [JITLink] Allow duplicate symbol names for locals.
Nov 16 2021, 4:19 PM · Restricted Project

Nov 12 2021

benlangmuir committed rG2a739f2789c3: [ORC][ORC-RT] Register type metadata from __swift5_types MachO section (authored by benlangmuir).
[ORC][ORC-RT] Register type metadata from __swift5_types MachO section
Nov 12 2021, 4:40 PM
benlangmuir closed D113811: [ORC][ORC-RT] Register type metadata from __swift5_types MachO section.
Nov 12 2021, 4:40 PM · Restricted Project, Restricted Project
benlangmuir requested review of D113811: [ORC][ORC-RT] Register type metadata from __swift5_types MachO section.
Nov 12 2021, 3:28 PM · Restricted Project, Restricted Project

Nov 11 2021

benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

Part of me wants to say that we should make these visibility macros conditional on the existing LLVM_ENABLE_DYLIB (sp?) option. If the user is statically linking LLVM, we should drop these annotations and allow the global visibility preset to take precedence.

Nov 11 2021, 2:06 PM · Restricted Project

Nov 10 2021

benlangmuir added a comment to D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.

but maybe linking more than one copy of LLVM is rare enough that the issue hasn't come up before?

Nov 10 2021, 2:16 PM · Restricted Project
benlangmuir added a reviewer for D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib: tstellar.
Nov 10 2021, 2:06 PM · Restricted Project
benlangmuir requested review of D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.
Nov 10 2021, 2:01 PM · Restricted Project

Nov 4 2021

benlangmuir committed rGa2639dcbe613: [ORC] Add a utility for adding missing "self" relocations to a Symbol (authored by benlangmuir).
[ORC] Add a utility for adding missing "self" relocations to a Symbol
Nov 4 2021, 3:01 PM
benlangmuir closed D113038: [ORC] Add a utility for adding missing "self" relocations to a Symbol.
Nov 4 2021, 3:01 PM · Restricted Project

Nov 2 2021

benlangmuir added inline comments to D113038: [ORC] Add a utility for adding missing "self" relocations to a Symbol.
Nov 2 2021, 11:37 AM · Restricted Project
benlangmuir requested review of D113038: [ORC] Add a utility for adding missing "self" relocations to a Symbol.
Nov 2 2021, 11:30 AM · Restricted Project

Oct 27 2021

benlangmuir committed rGbeb3d48262bc: [ORC-RT] Fix objc selector corruption (authored by benlangmuir).
[ORC-RT] Fix objc selector corruption
Oct 27 2021, 4:03 PM
benlangmuir closed D112671: [ORC-RT] Fix objc selector corruption.
Oct 27 2021, 4:03 PM · Restricted Project
benlangmuir requested review of D112671: [ORC-RT] Fix objc selector corruption.
Oct 27 2021, 3:50 PM · Restricted Project
benlangmuir committed rG3d13ee28914d: [ORC][ORC-RT] Enable the MachO platform for arm64 (authored by benlangmuir).
[ORC][ORC-RT] Enable the MachO platform for arm64
Oct 27 2021, 1:37 PM
benlangmuir closed D112656: [ORC][ORC-RT] Enable the MachO platform for arm64.
Oct 27 2021, 1:36 PM · Restricted Project, Restricted Project
benlangmuir requested review of D112656: [ORC][ORC-RT] Enable the MachO platform for arm64.
Oct 27 2021, 1:00 PM · Restricted Project, Restricted Project

Oct 21 2021

benlangmuir added a comment to D111768: [IPT] Restructure cache to allow lazy update following invalidation [NFC].

It looks like this caused an assertion failure on buildbots, would you mind reverting?

Oct 21 2021, 10:36 AM · Restricted Project
benlangmuir committed rG92a6dd6e50c8: [test][ORC-RT] Disable x86_64 tests when target arch does not match (authored by benlangmuir).
[test][ORC-RT] Disable x86_64 tests when target arch does not match
Oct 21 2021, 10:04 AM