This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Fix minor debug info bug in deleteDeadLoop
ClosedPublic

Authored by Orlando on Sep 5 2022, 7:34 AM.

Details

Summary

Using a DebugVariable as the set key rather than std::pair<DIVariable *, DIExpression *> ensures we don't accidently confuse multiple instances of inlined variables.

I just noticed this while in the area and don't have a test case, but I could probably hand-write one if necessary.

Diff Detail

Event Timeline

Orlando created this revision.Sep 5 2022, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 7:34 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Orlando requested review of this revision.Sep 5 2022, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 7:34 AM
jryans accepted this revision.Sep 7 2022, 12:52 PM

Thanks, looks sensible to me! 😄

It would be nice to cover with a test, but not absolutely required... I would suggest spending a small amount of time trying to craft one, but if it's not working out, it's fine to land this without it as well.

This revision is now accepted and ready to land.Sep 7 2022, 12:52 PM
This revision was landed with ongoing or failed builds.Nov 2 2022, 6:28 AM
This revision was automatically updated to reflect the committed changes.

Thanks for reviewing this @jryans. I've landed this with a test.