This is an archive of the discontinued LLVM Phabricator instance.

[Assignment Tracking][17/*] Account for assignment tracking in memcpyopt
ClosedPublic

Authored by Orlando on Sep 5 2022, 8:21 AM.

Details

Summary

A simple one, just maintained and propagate DIAssignID attachments.

Diff Detail

Event Timeline

Orlando created this revision.Sep 5 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 8:21 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Orlando requested review of this revision.Sep 5 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 8:21 AM
jmorse accepted this revision.Sep 9 2022, 6:43 AM
jmorse added a subscriber: jmorse.

LGTM, if you feel the call of duty then you could remove the tbaa metadata from the patch.

llvm/test/DebugInfo/Generic/assignment-tracking/memcpyopt/merge-stores.ll
23

More of a memset than a memcpy

This revision is now accepted and ready to land.Sep 9 2022, 6:43 AM
Orlando updated this revision to Diff 459081.Sep 9 2022, 8:35 AM
Orlando marked an inline comment as done.

LGTM, if you feel the call of duty then you could remove the tbaa metadata from the patch.

Done, thanks.

This revision was landed with ongoing or failed builds.Nov 15 2022, 3:52 AM
This revision was automatically updated to reflect the committed changes.