This is an archive of the discontinued LLVM Phabricator instance.

[Assignment Tracking][9/*] Don't drop DIAssignID in dropUnknownNonDebugMetadata
ClosedPublic

Authored by Orlando on Sep 5 2022, 5:14 AM.

Details

Summary

Make it difficult to accidently drop DIAssignID metadata attachments.

Diff Detail

Event Timeline

Orlando created this revision.Sep 5 2022, 5:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 5:14 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Orlando requested review of this revision.Sep 5 2022, 5:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 5:14 AM
jmorse added a subscriber: jmorse.Sep 7 2022, 4:17 AM

LGTM

llvm/lib/IR/Metadata.cpp
1408–1409

AS "NonDebug" is in the name of the function, we can probably get away with saying "DIAssignID is debug metadata, don't drop it".

Orlando updated this revision to Diff 458710.Sep 8 2022, 5:54 AM
Orlando marked an inline comment as done.
jmorse accepted this revision.Sep 13 2022, 9:45 AM
This revision is now accepted and ready to land.Sep 13 2022, 9:45 AM
This revision was landed with ongoing or failed builds.Nov 9 2022, 3:01 AM
This revision was automatically updated to reflect the committed changes.