Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[RISCV][test][NFC] Update branch-relaxation.ll with

Authored by piggynl on Aug 24 2022, 5:47 PM.



Update llvm/test/CodeGen/RISCV/branch-relaxation.ll with, according to

The tests don't seem to have been properly updated with llvm/test/CodeGen/RISCV/branch-relaxation.ll contains RV64 RUN lines but the corresponding CHECK lines are missing in some functions.

Looking more closely at this, I guess you tried to only include the CHECK-RV64 and CHECK-RV32 checks when relevant. That's a good instinct but I guess it goes a bit against how we normally use My understanding of the trade-off of using that tool is that the test updates are much easier, even if sometimes the CHECKs aren't as tight as something more tailormade.

Diff Detail

Event Timeline

piggynl created this revision.Aug 24 2022, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 5:47 PM
piggynl requested review of this revision.Aug 24 2022, 5:47 PM
luismarques accepted this revision.Aug 25 2022, 1:33 AM



Nit: remove the last sentence.

This revision is now accepted and ready to land.Aug 25 2022, 1:33 AM