Page MenuHomePhabricator

piggynl (Piggy)
User

Projects

User does not belong to any projects.

User Details

User Since
May 26 2022, 6:59 AM (17 w, 2 d)

Recent Activity

Mon, Sep 5

piggynl added a comment to D131863: [CodeGen] Fix restore blocks' BasicBlock information in branch relaxation.

Ping for review :)

Mon, Sep 5, 9:06 AM · Restricted Project, Restricted Project
piggynl added a comment to D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.

Ping for review :)

Mon, Sep 5, 9:06 AM · Restricted Project, Restricted Project

Sun, Sep 4

piggynl committed rG595c4a3c050a: [LLVM][docs] Update CMake.rst to follow the upgrade to C++ 17 [NFC] (authored by piggynl).
[LLVM][docs] Update CMake.rst to follow the upgrade to C++ 17 [NFC]
Sun, Sep 4, 6:58 PM · Restricted Project, Restricted Project
piggynl closed D133272: [LLVM][docs] Update CMake.rst to follow the upgrade to C++ 17.
Sun, Sep 4, 6:57 PM · Restricted Project, Restricted Project
piggynl requested review of D133272: [LLVM][docs] Update CMake.rst to follow the upgrade to C++ 17.
Sun, Sep 4, 6:59 AM · Restricted Project, Restricted Project

Mon, Aug 29

piggynl added a comment to D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.

Ping for review :)

Mon, Aug 29, 8:30 AM · Restricted Project, Restricted Project
piggynl updated the diff for D131863: [CodeGen] Fix restore blocks' BasicBlock information in branch relaxation.

Rebase and ping for review :)

Mon, Aug 29, 8:23 AM · Restricted Project, Restricted Project
piggynl updated the diff for D131862: Pre-commit test for D131863.
  • Rebase
  • Update the test with update_llc_test_checks.py
Mon, Aug 29, 8:20 AM · Restricted Project, Restricted Project

Aug 25 2022

piggynl committed rG395bda933f76: [RISCV][test] Update branch-relaxation.ll with update_llc_test_checks.py [NFC] (authored by piggynl).
[RISCV][test] Update branch-relaxation.ll with update_llc_test_checks.py [NFC]
Aug 25 2022, 2:02 AM · Restricted Project, Restricted Project
piggynl added a reverting change for rGc374789fba48: [RISCV][test] Update branch-relaxation.ll with update_llc_test_checks.py [NFC]: rGd098e45eed6b: Revert "[RISCV][test] Update branch-relaxation.ll with update_llc_test_checks..
Aug 25 2022, 2:02 AM · Restricted Project, Restricted Project
piggynl committed rGd098e45eed6b: Revert "[RISCV][test] Update branch-relaxation.ll with update_llc_test_checks. (authored by piggynl).
Revert "[RISCV][test] Update branch-relaxation.ll with update_llc_test_checks.
Aug 25 2022, 2:02 AM · Restricted Project, Restricted Project
piggynl closed D132625: [RISCV][test][NFC] Update branch-relaxation.ll with update_llc_test_checks.py.
Aug 25 2022, 2:02 AM · Restricted Project, Restricted Project
piggynl committed rGc374789fba48: [RISCV][test] Update branch-relaxation.ll with update_llc_test_checks.py [NFC] (authored by piggynl).
[RISCV][test] Update branch-relaxation.ll with update_llc_test_checks.py [NFC]
Aug 25 2022, 1:55 AM · Restricted Project, Restricted Project

Aug 24 2022

piggynl added a comment to D130560: [RISCV] Handle register spill in branch relaxation.

The tests don't seem to have been properly updated with update_llc_test_checks.py. llvm/test/CodeGen/RISCV/branch-relaxation.ll contains RV64 RUN lines but the corresponding CHECK lines are missing in some functions.

Looking more closely at this, I guess you tried to only include the CHECK-RV64 and CHECK-RV32 checks when relevant. That's a good instinct but I guess it goes a bit against how we normally use update_llc_test_checks.py. My understanding of the trade-off of using that tool is that the test updates are much easier, even if sometimes the CHECKs aren't as tight as something more tailormade.

Aug 24 2022, 5:49 PM · Restricted Project, Restricted Project
piggynl requested review of D132625: [RISCV][test][NFC] Update branch-relaxation.ll with update_llc_test_checks.py.
Aug 24 2022, 5:47 PM · Restricted Project, Restricted Project

Aug 23 2022

piggynl committed rG9c85382aded8: [RISCV] Handle register spill in branch relaxation (authored by piggynl).
[RISCV] Handle register spill in branch relaxation
Aug 23 2022, 10:31 PM · Restricted Project, Restricted Project
piggynl committed rGd51581ff2c3e: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible (authored by piggynl).
[RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible
Aug 23 2022, 10:31 PM · Restricted Project, Restricted Project
piggynl closed D130560: [RISCV] Handle register spill in branch relaxation.
Aug 23 2022, 10:31 PM · Restricted Project, Restricted Project
piggynl closed D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.
Aug 23 2022, 10:31 PM · Restricted Project, Restricted Project

Aug 17 2022

piggynl added a comment to D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.

Ping for kindly review :)

Aug 17 2022, 6:49 AM · Restricted Project, Restricted Project
piggynl retitled D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible from [TableGen] Mark MachineInstr with FrameIndex as not compressible to [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.
Aug 17 2022, 6:48 AM · Restricted Project, Restricted Project

Aug 14 2022

piggynl retitled D131549: [ADT] Make SmallSet::insert(const T &) return const_iterator from [ADT] Make SmallSet::insert(const T &) returns const_iterator to [ADT] Make SmallSet::insert(const T &) return const_iterator.
Aug 14 2022, 10:56 PM · Restricted Project, Restricted Project
piggynl committed rG8719faafdb3f: [ADT] Make SmallSet::insert(const T &) return const_iterator (authored by piggynl).
[ADT] Make SmallSet::insert(const T &) return const_iterator
Aug 14 2022, 10:55 PM · Restricted Project, Restricted Project
piggynl closed D131549: [ADT] Make SmallSet::insert(const T &) return const_iterator.
Aug 14 2022, 10:55 PM · Restricted Project, Restricted Project
piggynl added inline comments to D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.
Aug 14 2022, 11:29 AM · Restricted Project, Restricted Project
piggynl updated the diff for D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.
  • Change the type of BasicBlockInfo::RestoreBlocks from SmallVector to TinyPtrVector.
Aug 14 2022, 11:26 AM · Restricted Project, Restricted Project
piggynl added inline comments to D131865: Pre-commit test for D131587.
Aug 14 2022, 11:16 AM · Restricted Project, Restricted Project
piggynl requested review of D131865: Pre-commit test for D131587.
Aug 14 2022, 11:07 AM · Restricted Project, Restricted Project
piggynl added inline comments to D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.
Aug 14 2022, 10:38 AM · Restricted Project, Restricted Project
piggynl retitled D131862: Pre-commit test for D131863 from Pre-commit test to Pre-commit test for D131863.
Aug 14 2022, 10:30 AM · Restricted Project, Restricted Project
piggynl requested review of D131863: [CodeGen] Fix restore blocks' BasicBlock information in branch relaxation.
Aug 14 2022, 10:29 AM · Restricted Project, Restricted Project
piggynl requested review of D131862: Pre-commit test for D131863.
Aug 14 2022, 10:10 AM · Restricted Project, Restricted Project

Aug 10 2022

piggynl updated the diff for D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.
Aug 10 2022, 2:08 PM · Restricted Project, Restricted Project
piggynl updated the diff for D131549: [ADT] Make SmallSet::insert(const T &) return const_iterator.

Revise according to @dblaikie's comments.

Aug 10 2022, 1:27 PM · Restricted Project, Restricted Project
piggynl added inline comments to D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.
Aug 10 2022, 10:10 AM · Restricted Project, Restricted Project
piggynl updated the summary of D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.
Aug 10 2022, 10:10 AM · Restricted Project, Restricted Project
piggynl requested review of D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.
Aug 10 2022, 9:18 AM · Restricted Project, Restricted Project
piggynl added a comment to D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.

Ping :) Do we have any updates on this?

Aug 10 2022, 5:35 AM · Restricted Project, Restricted Project
piggynl updated the diff for D131549: [ADT] Make SmallSet::insert(const T &) return const_iterator.

Update comments.

Aug 10 2022, 2:23 AM · Restricted Project, Restricted Project
piggynl requested review of D131549: [ADT] Make SmallSet::insert(const T &) return const_iterator.
Aug 10 2022, 1:17 AM · Restricted Project, Restricted Project

Aug 8 2022

piggynl added a comment to D130560: [RISCV] Handle register spill in branch relaxation.

Thank you! Would you mind taking a look at D129999? This patch depends on it for estimating functions' sizes.

Aug 8 2022, 1:51 AM · Restricted Project, Restricted Project

Aug 6 2022

piggynl updated the diff for D130560: [RISCV] Handle register spill in branch relaxation.
Aug 6 2022, 12:36 AM · Restricted Project, Restricted Project

Aug 5 2022

piggynl abandoned D131249: [BranchRelaxation] Remove param BrOffset from TargetInstrInfo::insertIndirectBranch() [NFC].
Aug 5 2022, 4:58 AM · Restricted Project, Restricted Project
piggynl requested review of D131249: [BranchRelaxation] Remove param BrOffset from TargetInstrInfo::insertIndirectBranch() [NFC].
Aug 5 2022, 2:05 AM · Restricted Project, Restricted Project

Aug 4 2022

piggynl added a comment to D130560: [RISCV] Handle register spill in branch relaxation.

Ping :) Is there anything else I can do to improve this?

Aug 4 2022, 6:38 AM · Restricted Project, Restricted Project

Aug 2 2022

piggynl added a comment to D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.

Can you update the title to say make "Mark MachineInstr with FrameIndex as not compressible". The phrase "incomplete MachineInstr" is not very clear. I would interpret it as a MachineInstr with less operands than it's supposed to have. A MachineInstr with a FrameIndex is a completely valid MachineInstr so I wouldn't call it incomplete.

Aug 2 2022, 11:50 AM · Restricted Project, Restricted Project
piggynl retitled D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible from [TableGen] Mark incomplete MachineInstr as not compressible to [TableGen] Mark MachineInstr with FrameIndex as not compressible.
Aug 2 2022, 11:48 AM · Restricted Project, Restricted Project
piggynl added a comment to D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.

Sure! I'll explain the details about why I want to make this change.

Aug 2 2022, 11:32 AM · Restricted Project, Restricted Project
piggynl added a comment to D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.

Ping for kindly review :)

Aug 2 2022, 8:16 AM · Restricted Project, Restricted Project

Jul 28 2022

piggynl added inline comments to D130560: [RISCV] Handle register spill in branch relaxation.
Jul 28 2022, 11:24 PM · Restricted Project, Restricted Project
piggynl added a comment to D130560: [RISCV] Handle register spill in branch relaxation.

There seems to be a problem here: if we perform only some operations on registers without sd after a jump (which can easily happen if only a few short instructions are executed between jumps), we then jump to another place. If we still restore immediately in this case, we are actually wasting resources.

Jul 28 2022, 11:23 PM · Restricted Project, Restricted Project
piggynl added inline comments to D130560: [RISCV] Handle register spill in branch relaxation.
Jul 28 2022, 11:22 PM · Restricted Project, Restricted Project
piggynl updated the diff for D130560: [RISCV] Handle register spill in branch relaxation.

Reuse scavenging spill slot for scratch register's spill slot in branch relaxation.

Jul 28 2022, 11:20 PM · Restricted Project, Restricted Project
piggynl added inline comments to D130560: [RISCV] Handle register spill in branch relaxation.
Jul 28 2022, 12:10 AM · Restricted Project, Restricted Project

Jul 27 2022

piggynl updated the diff for D130560: [RISCV] Handle register spill in branch relaxation.

Remove unnecessary #include.

Jul 27 2022, 6:16 PM · Restricted Project, Restricted Project

Jul 26 2022

piggynl updated the diff for D130560: [RISCV] Handle register spill in branch relaxation.

Fix code style via clang-format.

Jul 26 2022, 11:23 PM · Restricted Project, Restricted Project
piggynl updated the diff for D130560: [RISCV] Handle register spill in branch relaxation.

Add test for a large stack that requires adjusting the offset of BranchRelaxationScratchFrameIndex.

Jul 26 2022, 11:20 PM · Restricted Project, Restricted Project
piggynl abandoned D129975: [CodeGen] Add MachineFunction::estimateSizeInBytes().
Jul 26 2022, 8:52 PM · Restricted Project, Restricted Project
piggynl updated the diff for D130560: [RISCV] Handle register spill in branch relaxation.

Fix code style via clang-format.

Jul 26 2022, 8:37 PM · Restricted Project, Restricted Project
piggynl updated the diff for D130560: [RISCV] Handle register spill in branch relaxation.
  • More conservative estimate for branches in EstimateFunctionSizeInBytes.
Jul 26 2022, 8:29 PM · Restricted Project, Restricted Project
piggynl added inline comments to D130560: [RISCV] Handle register spill in branch relaxation.
Jul 26 2022, 5:19 AM · Restricted Project, Restricted Project
piggynl updated the summary of D130560: [RISCV] Handle register spill in branch relaxation.
Jul 26 2022, 5:14 AM · Restricted Project, Restricted Project
piggynl requested review of D130560: [RISCV] Handle register spill in branch relaxation.
Jul 26 2022, 3:24 AM · Restricted Project, Restricted Project
piggynl added reviewers for D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible: apazos, asb, lewis-revill.
Jul 26 2022, 2:23 AM · Restricted Project, Restricted Project

Jul 19 2022

piggynl planned changes to D129975: [CodeGen] Add MachineFunction::estimateSizeInBytes().

ARM hard-coded EK_Inline as jump table encoding in rG8d3ba7349c2137f1a7f68c0ce5c1345496fc0b63. As a result, std::max(JTI->getEntrySize(DL), JTI->getEntryAlignment(DL)) always returns 1, which causes test/CodeGen/Thumb/large-fn-switch.ll to fail.

Jul 19 2022, 6:35 AM · Restricted Project, Restricted Project

Jul 18 2022

piggynl updated the diff for D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.

Update test.

Jul 18 2022, 7:27 AM · Restricted Project, Restricted Project
piggynl added a reviewer for D129975: [CodeGen] Add MachineFunction::estimateSizeInBytes(): lattner.
Jul 18 2022, 4:49 AM · Restricted Project, Restricted Project
piggynl requested review of D129999: [RISCV][TableGen] Mark MachineInstr with FrameIndex as not compressible.
Jul 18 2022, 4:36 AM · Restricted Project, Restricted Project

Jul 17 2022

piggynl updated the diff for D129975: [CodeGen] Add MachineFunction::estimateSizeInBytes().

Fix compile error.

Jul 17 2022, 3:15 PM · Restricted Project, Restricted Project
piggynl retitled D129975: [CodeGen] Add MachineFunction::estimateSizeInBytes() from [llvm] Add MachineFunction::estimateSizeInBytes() to [CodeGen] Add MachineFunction::estimateSizeInBytes().
Jul 17 2022, 2:57 PM · Restricted Project, Restricted Project
piggynl requested review of D129975: [CodeGen] Add MachineFunction::estimateSizeInBytes().
Jul 17 2022, 2:56 PM · Restricted Project, Restricted Project

May 27 2022

piggynl updated piggynl.
May 27 2022, 12:20 AM

May 26 2022

piggynl committed rG842e48bd6577: [demangler][RISCV] Fix for long double (authored by piggynl).
[demangler][RISCV] Fix for long double
May 26 2022, 10:54 PM · Restricted Project, Restricted Project
piggynl closed D126480: [demangler][RISCV] Fix for long double.
May 26 2022, 10:53 PM · Restricted Project, Restricted Project, Restricted Project
piggynl updated the diff for D126480: [demangler][RISCV] Fix for long double.

(included more context)

May 26 2022, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
piggynl updated the summary of D126480: [demangler][RISCV] Fix for long double.
May 26 2022, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
piggynl requested review of D126480: [demangler][RISCV] Fix for long double.
May 26 2022, 8:29 AM · Restricted Project, Restricted Project, Restricted Project
piggynl updated piggynl.
May 26 2022, 7:02 AM