Page MenuHomePhabricator

[libc++] Make <ranges> non-experimental
ClosedPublic

Authored by ldionne on Aug 18 2022, 11:08 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGb8cb1dc9ea87: [libc++] Make <ranges> non-experimental
Summary

When we ship LLVM 16, <ranges> won't be considered experimental anymore.
We might as well do this sooner rather than later.

Diff Detail

Event Timeline

ldionne created this revision.Aug 18 2022, 11:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2022, 11:08 AM
ldionne requested review of this revision.Aug 18 2022, 11:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2022, 11:08 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Aug 18 2022, 1:28 PM

LGTM assuming you grepped for _LIBCPP_HAS_NO_INCOMPLTE_RANGES and not just !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES) or something like that.

libcxx/test/std/ranges/range.adaptors/range.join.view/iterator/iter.move.pass.cpp
31

Can we get something in generated output that checks for trailing whitespaces?

This revision is now accepted and ready to land.Aug 18 2022, 1:28 PM
ldionne marked an inline comment as done.Aug 18 2022, 1:59 PM

LGTM assuming you grepped for _LIBCPP_HAS_NO_INCOMPLTE_RANGES and not just !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES) or something like that.

Yes, I did. Without the typo :-)

libcxx/test/std/ranges/range.adaptors/range.join.view/iterator/iter.move.pass.cpp
31
This revision was automatically updated to reflect the committed changes.
ldionne marked an inline comment as done.

This is great!

In general I love this, but did you or somebody else verify there are no more open API/ABI breaking papers and/or LWG issues?

Great. thanks!