This is an archive of the discontinued LLVM Phabricator instance.

Add -misc-const-correctness to .clang-tidy
ClosedPublic

Authored by aeubanks on Aug 8 2022, 10:18 AM.

Reviewers

Commits

rGf181dff0846c: Add -misc-const-correctness to .clang-tidy

Summary

I keep getting suggestions from clangd to add 'const' to a bunch of local variables, which is not LLVM's style. This suppresses those.

	Time	Test
	2,820 ms	x64 debian > libFuzzer.libFuzzer::fuzzer-finalstats.test

aeubanks requested review of this revision.Aug 8 2022, 10:18 AM

thanks, this also came up in D54943. people are definitely annoyed by this and LLVM codebase needs to be cleaned for it if we want to enable it.

This revision is now accepted and ready to land.Aug 8 2022, 10:31 AM

LGTM!

This revision was landed with ongoing or failed builds.Aug 8 2022, 1:01 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

2 lines

	Checks: '-,clang-diagnostic-,llvm-,misc-,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-misc-no-recursion,readability-identifier-naming'			Checks: '-,clang-diagnostic-,llvm-,misc-,-misc-const-correctness,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-misc-no-recursion,readability-identifier-naming'
	CheckOptions:			CheckOptions:
	- key: readability-identifier-naming.ClassCase			- key: readability-identifier-naming.ClassCase
	value: CamelCase			value: CamelCase
	- key: readability-identifier-naming.EnumCase			- key: readability-identifier-naming.EnumCase
	value: CamelCase			value: CamelCase
	- key: readability-identifier-naming.FunctionCase			- key: readability-identifier-naming.FunctionCase
	value: camelBack			value: camelBack
	# Exclude from scanning as this is an exported symbol used for fuzzing			# Exclude from scanning as this is an exported symbol used for fuzzing
	Show All 17 Lines