This is an archive of the discontinued LLVM Phabricator instance.

Differential D131414

Add -misc-const-correctness to .clang-tidy
ClosedPublic

Authored by aeubanks on Aug 8 2022, 10:18 AM.

Download Raw Diff

Details

Reviewers

hokein
kadircet
aaron.ballman

Commits

rGf181dff0846c: Add -misc-const-correctness to .clang-tidy

Summary

I keep getting suggestions from clangd to add 'const' to a bunch of local variables, which is not LLVM's style. This suppresses those.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

aeubanks created this revision.Aug 8 2022, 10:18 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 10:18 AM

Herald added subscribers: usaxena95, kadircet. · View Herald Transcript

aeubanks requested review of this revision.Aug 8 2022, 10:18 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 10:18 AM

Herald added subscribers: llvm-commits, ilya-biryukov, aheejin. · View Herald Transcript

thanks, this also came up in D54943. people are definitely annoyed by this and LLVM codebase needs to be cleaned for it if we want to enable it.

This revision is now accepted and ready to land.Aug 8 2022, 10:31 AM

LGTM!

Harbormaster completed remote builds in B179953: Diff 450862.Aug 8 2022, 12:05 PM

This revision was landed with ongoing or failed builds.Aug 8 2022, 1:01 PM

Closed by commit rGf181dff0846c: Add -misc-const-correctness to .clang-tidy (authored by aeubanks). · Explain Why

This revision was automatically updated to reflect the committed changes.

aeubanks added a commit: rGf181dff0846c: Add -misc-const-correctness to .clang-tidy.

mehdi_amini mentioned this in D149018: Update .clang-tidy to drop static -> anonymous namespace warnings.Apr 23 2023, 1:04 PM

Revision Contents

Path

Size

2 lines

Diff 450911

.clang-tidy

	Checks: '-,clang-diagnostic-,llvm-,misc-,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-misc-no-recursion,readability-identifier-naming'			Checks: '-,clang-diagnostic-,llvm-,misc-,-misc-const-correctness,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-misc-no-recursion,readability-identifier-naming'
	CheckOptions:			CheckOptions:
	- key: readability-identifier-naming.ClassCase			- key: readability-identifier-naming.ClassCase
	value: CamelCase			value: CamelCase
	- key: readability-identifier-naming.EnumCase			- key: readability-identifier-naming.EnumCase
	value: CamelCase			value: CamelCase
	- key: readability-identifier-naming.FunctionCase			- key: readability-identifier-naming.FunctionCase
	value: camelBack			value: camelBack
	# Exclude from scanning as this is an exported symbol used for fuzzing			# Exclude from scanning as this is an exported symbol used for fuzzing
	Show All 17 Lines