This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11][NFC] Split large tests
ClosedPublic

Authored by dp on Aug 8 2022, 6:51 AM.

Details

Summary

Rationale:

  • make tests more manageable;
  • improve testing performance;
  • prepare to improve GFX11 test coverage.

Diff Detail

Event Timeline

dp created this revision.Aug 8 2022, 6:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 6:51 AM
dp requested review of this revision.Aug 8 2022, 6:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 6:51 AM
arsenm accepted this revision.Aug 8 2022, 6:55 AM
This revision is now accepted and ready to land.Aug 8 2022, 6:55 AM
Joe_Nash accepted this revision.Aug 8 2022, 6:56 AM
Joe_Nash added a reviewer: rampitec.

LGTM. For the past few subtargets disassembler tests have been all in 1 file, but that just might be by accident. @rampitec may have thoughts about that.

dp added a comment.Aug 8 2022, 7:04 AM

There is a separate issue concerning large lit tests: https://github.com/llvm/llvm-project/issues/47894
If nobody minds, I'll split other large disassembler tests as well.

rampitec accepted this revision.Aug 8 2022, 10:43 AM

LGTM. For the past few subtargets disassembler tests have been all in 1 file, but that just might be by accident. @rampitec may have thoughts about that.

It is just for historic reasons, having these split would be nice too.

This revision was automatically updated to reflect the committed changes.