This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] Refresh base definitions to latest spec (v1.6)
ClosedPublic

Authored by antiagainst on Aug 5 2022, 1:59 PM.

Details

Summary

This commit updates all SPIR-V enum definitions to match the latest
specification (v1.6 revision 2). Along the way, fixed some issues
in gen_spirv_dialect.py and added a new script for refreshing
all op definitions for such cases.

Diff Detail

Event Timeline

antiagainst created this revision.Aug 5 2022, 1:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 1:59 PM
antiagainst requested review of this revision.Aug 5 2022, 1:59 PM
kuhar accepted this revision.Aug 5 2022, 2:11 PM
kuhar added inline comments.
mlir/utils/spirv/refresh_inst.sh
15

Don't we need to quote current_dir in case there are spaces? I'm used to quoting all paths: https://google.github.io/styleguide/shellguide.html#quoting

26

Same here

This revision is now accepted and ready to land.Aug 5 2022, 2:11 PM
antiagainst marked 2 inline comments as done.Aug 8 2022, 9:09 AM
antiagainst added inline comments.
mlir/utils/spirv/refresh_inst.sh
15

Good point. Done.

This revision was landed with ongoing or failed builds.Aug 8 2022, 9:23 AM
This revision was automatically updated to reflect the committed changes.
antiagainst marked an inline comment as done.