This matches user expectations.
actually, would HighlightingKind::LocalVariable be more appropriate?
The standard calls this a "The function-local predefined variable".
Admittedly I have a tendency to think of it as macro-like by analogy with __LINE__ etc but this model is observably wrong: it breaks down with templates and in other ways.
By the way: How do I change the commit message when using arc? It seems to ignore all subsequent changes other than in the code itself, and now the patch is in the repo with a misleading commit message.
Yeah that's unfortunate and I do it myself all the time :-(
When I remember, my workflow is to amend the commit message locally with git, and then arc diff --verbatim will push this into the phab description (in addition to the usual snapshotting behavior).
But often I forget and edit it in phab, and I don't know of a command to pull those edits down into my git repo.
I ended up always doing this for landing changes:
$ git switch main $ git pull --ff-only $ arc patch --nobranch D123456 $ git push origin main
That way I get the latest description from phabricator and also the reviewed-by tags.
And I basically ignore what the commit messages says on my branch while it's WIP, phab is source of truth after the initial change.