Page MenuHomePhabricator

ckandeler (Christian Kandeler)
User

Projects

User does not belong to any projects.

User Details

User Since
May 19 2020, 5:48 AM (6 w, 5 d)

Recent Activity

Thu, Jul 2

ckandeler added a comment to D82629: [libclang] Fix crash when visiting a captured VLA..

I suppose it boils down to whether the visit() function is supposed to except null arguments or not. Since I don't know the answer to that, I added the check at the caller. From the description of the linked patch, it appears that other places are also calling the function with a null pointer, but that could just mean that these should be fixed independently. Someone with better knowledge of the code would have to make that decision.

Thu, Jul 2, 1:01 AM · Restricted Project

Mon, Jun 29

ckandeler updated the diff for D82629: [libclang] Fix crash when visiting a captured VLA..

Fixed formatting issues.

Mon, Jun 29, 5:54 AM · Restricted Project

Fri, Jun 26

ckandeler created D82629: [libclang] Fix crash when visiting a captured VLA..
Fri, Jun 26, 2:08 AM · Restricted Project

Tue, Jun 16

ckandeler added a comment to D80279: [libclang] Extend clang_Cursor_Evaluate()..

A kind reminder that I need someone with commit rights to merge this for me.

Tue, Jun 16, 1:04 AM · Restricted Project

May 22 2020

ckandeler added a comment to D80279: [libclang] Extend clang_Cursor_Evaluate()..

Thanks for the quick review. I don't have commit access, so can someone please commit it for me?

May 22 2020, 1:13 AM · Restricted Project

May 20 2020

ckandeler added a reviewer for D80279: [libclang] Extend clang_Cursor_Evaluate().: akyrtzi.
May 20 2020, 2:07 AM · Restricted Project
ckandeler created D80279: [libclang] Extend clang_Cursor_Evaluate()..
May 20 2020, 1:35 AM · Restricted Project