Page MenuHomePhabricator

ckandeler (Christian Kandeler)
User

Projects

User does not belong to any projects.

User Details

User Since
May 19 2020, 5:48 AM (56 w, 3 d)

Recent Activity

May 10 2021

ckandeler added a comment to D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage.

No problem, thanks!

May 10 2021, 5:59 AM · Restricted Project
ckandeler added a comment to D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage.

ping. Any chance of getting this pushed?

May 10 2021, 5:13 AM · Restricted Project

May 3 2021

ckandeler added a comment to D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage.

Would you mind pushing this?

May 3 2021, 12:17 AM · Restricted Project

Apr 30 2021

ckandeler requested review of D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage.
Apr 30 2021, 5:23 AM · Restricted Project

Apr 23 2021

ckandeler added a comment to D101057: [clangd] Allow AST request without range.

Want me to land this for you?

Apr 23 2021, 7:10 AM · Restricted Project
ckandeler updated the diff for D101057: [clangd] Allow AST request without range.

Fixed remaining issues

Apr 23 2021, 7:08 AM · Restricted Project
ckandeler updated the diff for D101057: [clangd] Allow AST request without range.

"top-level" -> "root"

Apr 23 2021, 5:45 AM · Restricted Project
ckandeler updated the diff for D101057: [clangd] Allow AST request without range.

Fixed TU traversal

Apr 23 2021, 5:44 AM · Restricted Project
ckandeler updated the diff for D101057: [clangd] Allow AST request without range.

Addressed clang-tidy and clang-format comments

Apr 23 2021, 2:00 AM · Restricted Project

Apr 22 2021

ckandeler updated the diff for D101057: [clangd] Allow AST request without range.

Addressed reviewer comments.

Apr 22 2021, 7:54 AM · Restricted Project
ckandeler added a comment to D101057: [clangd] Allow AST request without range.

Only real issue is I think we should update the signature on ClangdServer.

Apr 22 2021, 6:32 AM · Restricted Project
ckandeler requested review of D101057: [clangd] Allow AST request without range.
Apr 22 2021, 5:38 AM · Restricted Project

Jul 10 2020

ckandeler accepted D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects.
Jul 10 2020, 2:57 AM · Restricted Project
ckandeler added a comment to D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects.

I can confirm that the test case crashes without the null pointer check and passes with the check.

Jul 10 2020, 2:56 AM · Restricted Project

Jul 7 2020

ckandeler added a comment to D82629: [libclang] Fix crash when visiting a captured VLA..

@ckandeler do you have commit access or do you want me to land the patch?

Jul 7 2020, 12:47 AM · Restricted Project

Jul 2 2020

ckandeler added a comment to D82629: [libclang] Fix crash when visiting a captured VLA..

I suppose it boils down to whether the visit() function is supposed to accept null arguments or not. Since I don't know the answer to that, I added the check at the caller. From the description of the linked patch, it appears that other places are also calling the function with a null pointer, but that could just mean that these should be fixed independently. Someone with better knowledge of the code would have to make that decision.

Jul 2 2020, 1:01 AM · Restricted Project

Jun 29 2020

ckandeler updated the diff for D82629: [libclang] Fix crash when visiting a captured VLA..

Fixed formatting issues.

Jun 29 2020, 5:54 AM · Restricted Project

Jun 26 2020

ckandeler created D82629: [libclang] Fix crash when visiting a captured VLA..
Jun 26 2020, 2:08 AM · Restricted Project

Jun 16 2020

ckandeler added a comment to D80279: [libclang] Extend clang_Cursor_Evaluate()..

A kind reminder that I need someone with commit rights to merge this for me.

Jun 16 2020, 1:04 AM · Restricted Project

May 22 2020

ckandeler added a comment to D80279: [libclang] Extend clang_Cursor_Evaluate()..

Thanks for the quick review. I don't have commit access, so can someone please commit it for me?

May 22 2020, 1:13 AM · Restricted Project

May 20 2020

ckandeler added a reviewer for D80279: [libclang] Extend clang_Cursor_Evaluate().: akyrtzi.
May 20 2020, 2:07 AM · Restricted Project
ckandeler created D80279: [libclang] Extend clang_Cursor_Evaluate()..
May 20 2020, 1:35 AM · Restricted Project