This is an archive of the discontinued LLVM Phabricator instance.

[SPIRV] use tablegen to create SPIRVBaseInfo*
ClosedPublic

Authored by iliya-diyachkov on Jul 25 2022, 2:31 PM.

Details

Summary

The patch replaces SPIRVBaseInfo.* previously created using macros by the tablegen approach. There are many small changes in other files (in names of namespace) because tablegen cannot generate enum classes, so table-generated enums are wrapped in a namespaces with the same name. Also, functions in SPIRVUtils are moved to the llvm namespace.

Diff Detail

Event Timeline

iliya-diyachkov requested review of this revision.Jul 25 2022, 2:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 2:31 PM

Fix building by clang.

mpaszkowski accepted this revision.Aug 1 2022, 8:52 AM

Thank you for preparing the patch @iliya-diyachkov! LGTM!

This revision is now accepted and ready to land.Aug 1 2022, 8:52 AM
This revision was landed with ongoing or failed builds.Aug 1 2022, 3:15 PM
This revision was automatically updated to reflect the committed changes.
llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp