This is an archive of the discontinued LLVM Phabricator instance.

Differential D130400

[clang][dataflow] ArrayRef'ize debugString()
ClosedPublic

Authored by gribozavr on Jul 22 2022, 2:49 PM.

Details

Reviewers
NoQ
wyt
ymandel
samestep
sgatev
Commits
rG589ddd7fe8e4: [clang][dataflow] ArrayRef'ize debugString()

Diff Detail

Event Timeline

gribozavr created this revision.Jul 22 2022, 2:49 PM
Herald added a reviewer: NoQ. · View Herald TranscriptJul 22 2022, 2:49 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: martong, tschuett, xazax.hun. · View Herald Transcript
gribozavr requested review of this revision.Jul 22 2022, 2:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2022, 2:49 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
gribozavr2 added reviewers: wyt, ymandel, samestep, sgatev.Jul 22 2022, 2:50 PM
ymandel accepted this revision.Jul 22 2022, 3:05 PM
This revision is now accepted and ready to land.Jul 22 2022, 3:05 PM
Harbormaster completed remote builds in B177120: Diff 446989.Jul 22 2022, 3:40 PM
This revision was landed with ongoing or failed builds.Jul 22 2022, 4:16 PM
Closed by commit rG589ddd7fe8e4: [clang][dataflow] ArrayRef'ize debugString() (authored by gribozavr). · Explain Why
This revision was automatically updated to reflect the committed changes.
gribozavr added a commit: rG589ddd7fe8e4: [clang][dataflow] ArrayRef'ize debugString().

Revision Contents

PathSize
clang/
include/
clang/
Analysis/
FlowSensitive/
2 lines
lib/
Analysis/
FlowSensitive/
5 lines

Diff 446989

clang/include/clang/Analysis/FlowSensitive/DebugSupport.h

Show All 40 Lines
/// Atomic booleans appearing in `Constraints` and `Result` are assigned to /// Atomic booleans appearing in `Constraints` and `Result` are assigned to
/// labels either specified in `AtomNames` or created by default rules as B0, /// labels either specified in `AtomNames` or created by default rules as B0,
/// B1, ... /// B1, ...
/// ///
/// Requirements: /// Requirements:
/// ///
/// Names assigned to atoms should not be repeated in `AtomNames`. /// Names assigned to atoms should not be repeated in `AtomNames`.
std::string debugString( std::string debugString(
const std::vector<BoolValue *> &Constraints, const Solver::Result &Result, ArrayRef<BoolValue *> Constraints, const Solver::Result &Result,
llvm::DenseMap<const AtomicBoolValue *, std::string> AtomNames = {{}}); llvm::DenseMap<const AtomicBoolValue *, std::string> AtomNames = {{}});
inline std::string debugString( inline std::string debugString(
const llvm::DenseSet<BoolValue *> &Constraints, const llvm::DenseSet<BoolValue *> &Constraints,
const Solver::Result &Result, const Solver::Result &Result,
llvm::DenseMap<const AtomicBoolValue *, std::string> AtomNames = {{}}) { llvm::DenseMap<const AtomicBoolValue *, std::string> AtomNames = {{}}) {
std::vector<BoolValue *> ConstraintsVec(Constraints.begin(), std::vector<BoolValue *> ConstraintsVec(Constraints.begin(),
Constraints.end()); Constraints.end());
return debugString(ConstraintsVec, Result, std::move(AtomNames)); return debugString(ConstraintsVec, Result, std::move(AtomNames));
} }
} // namespace dataflow } // namespace dataflow
} // namespace clang } // namespace clang
#endif // LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_DEBUGSUPPORT_H_ #endif // LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_DEBUGSUPPORT_H_

clang/lib/Analysis/FlowSensitive/DebugSupport.cpp

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines default:
llvm_unreachable("Unhandled value kind"); llvm_unreachable("Unhandled value kind");
} }
auto Indent = Depth * 4; auto Indent = Depth * 4;
return formatv("{0}", fmt_pad(S, Indent, 0)); return formatv("{0}", fmt_pad(S, Indent, 0));
} }
/// Returns a string representation of a set of boolean `Constraints` and the /// Returns a string representation of a set of boolean `Constraints` and the
/// `Result` of satisfiability checking on the `Constraints`. /// `Result` of satisfiability checking on the `Constraints`.
std::string debugString(const std::vector<BoolValue *> &Constraints, std::string debugString(ArrayRef<BoolValue *> &Constraints,
const Solver::Result &Result) { const Solver::Result &Result) {
auto Template = R"( auto Template = R"(
Constraints Constraints
------------ ------------
{0:$[ {0:$[
]} ]}
------------ ------------
▲ Show 20 Lines • Show All 86 Lines • ▼ Show 20 Lines
std::string std::string
debugString(const BoolValue &B, debugString(const BoolValue &B,
llvm::DenseMap<const AtomicBoolValue *, std::string> AtomNames) { llvm::DenseMap<const AtomicBoolValue *, std::string> AtomNames) {
return DebugStringGenerator(std::move(AtomNames)).debugString(B); return DebugStringGenerator(std::move(AtomNames)).debugString(B);
} }
std::string std::string
debugString(const std::vector<BoolValue *> &Constraints, debugString(ArrayRef<BoolValue *> Constraints, const Solver::Result &Result,
const Solver::Result &Result,
llvm::DenseMap<const AtomicBoolValue *, std::string> AtomNames) { llvm::DenseMap<const AtomicBoolValue *, std::string> AtomNames) {
return DebugStringGenerator(std::move(AtomNames)) return DebugStringGenerator(std::move(AtomNames))
.debugString(Constraints, Result); .debugString(Constraints, Result);
} }
} // namespace dataflow } // namespace dataflow
} // namespace clang } // namespace clang