User Details
- User Since
- Jun 7 2022, 3:20 AM (9 w, 2 d)
Today
Initialise DeclCtx field with nullptr.
Yesterday
Relocate function and fix comment for consistency.
Fri, Aug 5
Rebase to head.
Wed, Aug 3
Formatting fixes.
Update DeclCtx when pushing/popping calls.
Tue, Jul 26
Wed, Jul 13
Tue, Jul 12
Removed unused imports in SolverTest.cpp
Address comments.
Address comment on renaming parameter. Add const qualifier to BoolValue input to debugString.
Address comments: add used import, remove unused imports.
Jul 12 2022
Change propagated from parent patch.
Move DebugStringGenerator class into anonymous namespace.
Remove unnecessary enum keyword.
Fix use after move.
Fix comment, remove unused import.
Address comments.
Address comments.
Address comments on renaming. Removed test fixture class, replacing TEST_F with TEST.
Use std::vector as input to debugString to maintain order stability of boolean constraints to enable testing. debugString which takes a llvm::DenseSet<BoolValue*> is now a wrapper around the logic applied to std::vector.
Minor fixes.
Extract recursion into boolean subvalues into separate statements to enforce order of evaluation.
Update CMakeList for DebugSupportTest.cpp
Jul 7 2022
Remove decomposing declarations which are not available in llvm.
Replace std::optional with llvm::Optional
Fix comment.
Address comments.
Make scope resolution consistent (Solver:: instead of WatchedLiteralsSolver::).
Typo fix.
Address comments.
Jul 6 2022
Jun 27 2022
Add assert message.
Propagate change from parent patch.
Add macro for only testing asserts in debug mode.
Fix comment.
Assert that user does not try to substitute true/false booleans.
Address comments.
Fix comment.
Address comments - add example to buildAndSubstituteFlowCondition doc comment, add tests for atomic and negated flow condition.
Jun 24 2022
Propagate change from parent patch.
Rename checkUnsatisfiable to isUnsatisfiable
Address comments.
Rename createIff to getOrCreateIff based on change in parent patch.
Address comments - rename createIff/Implication to getOrCreateIff/Implication and add tests for these functions
Fix comment.
Could you elaborate on why do we need this?
We are currently working on a pointer nullability analysis here: https://github.com/google/crubit/tree/main/nullability_verification.
One of the things we are trying to do is to check if the flow condition is independent of a variable, done by checking if the formula regardless if the variable is substituted to true or false - requiring buildAndSubstituteFlowCondition.
Address comments.
Address comments.