Page MenuHomePhabricator

ymandel (Yitzhak Mandelbaum)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2018, 12:45 PM (42 w, 3 d)

Recent Activity

Thu, Jul 18

ymandel committed rG3f1ab737e219: [LibTooling] Relax Transformer to allow rewriting macro expansions (authored by ymandel).
[LibTooling] Relax Transformer to allow rewriting macro expansions
Thu, Jul 18, 10:45 AM
ymandel committed rL366473: [LibTooling] Relax Transformer to allow rewriting macro expansions.
[LibTooling] Relax Transformer to allow rewriting macro expansions
Thu, Jul 18, 10:44 AM
ymandel closed D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.
Thu, Jul 18, 10:44 AM · Restricted Project, Restricted Project
ymandel committed rG2e97a1e19ef5: [LibTooling] Add function to translate and validate source range for editing (authored by ymandel).
[LibTooling] Add function to translate and validate source range for editing
Thu, Jul 18, 10:32 AM
ymandel committed rL366469: [LibTooling] Add function to translate and validate source range for editing.
[LibTooling] Add function to translate and validate source range for editing
Thu, Jul 18, 10:26 AM
ymandel closed D64924: [LibTooling] Add function to translate and validate source range for editing.
Thu, Jul 18, 10:26 AM · Restricted Project, Restricted Project
ymandel added inline comments to D64893: Ask confirmation when `git llvm push` will push multiple commits.
Thu, Jul 18, 10:07 AM · Restricted Project
ymandel added inline comments to D64924: [LibTooling] Add function to translate and validate source range for editing.
Thu, Jul 18, 9:47 AM · Restricted Project, Restricted Project
ymandel updated the diff for D64924: [LibTooling] Add function to translate and validate source range for editing.

Added overload.

Thu, Jul 18, 9:47 AM · Restricted Project, Restricted Project
ymandel updated the diff for D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

remove unneeded include

Thu, Jul 18, 8:16 AM · Restricted Project, Restricted Project
ymandel added inline comments to D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.
Thu, Jul 18, 8:16 AM · Restricted Project, Restricted Project
ymandel added a child revision for D64924: [LibTooling] Add function to translate and validate source range for editing: D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.
Thu, Jul 18, 8:16 AM · Restricted Project, Restricted Project
ymandel updated the diff for D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

Moved makeValidRange to its own revision and rebased onto that.

Thu, Jul 18, 8:16 AM · Restricted Project, Restricted Project
ymandel added a parent revision for D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions: D64924: [LibTooling] Add function to translate and validate source range for editing.
Thu, Jul 18, 8:16 AM · Restricted Project, Restricted Project
ymandel updated the diff for D64924: [LibTooling] Add function to translate and validate source range for editing.

define matcher instead of operator==

Thu, Jul 18, 8:04 AM · Restricted Project, Restricted Project
ymandel created D64924: [LibTooling] Add function to translate and validate source range for editing.
Thu, Jul 18, 7:56 AM · Restricted Project, Restricted Project

Wed, Jul 17

ymandel added a comment to D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

This seems like a good candidate for configuration -- the user could then choose which mode to run in. But, I'm also open to just reporting these conditions as errors. It's already in a context that returns Expected, so its no trouble; it's just a matter of choosing what we think is "correct".

WRT to returning Expected vs Optional. Either seems fine and in the spirit of the library, depending on whether we want to produce more detailed errors. However, if we choose Optional let's stick to it, as practice shows switching from Optional to Expected correctly is almost impossible, as that requires a lot of attention to make sure all clients consume the errors (and given that it's an error case, tests often don't catch unconsumed errors).
I would personally go with Optional here (meaning the client code would have to say something generic like could not map from macro expansion to source code). But up to you, not a strong preference.

Wed, Jul 17, 10:54 AM · Restricted Project, Restricted Project

Tue, Jul 16

ymandel updated the diff for D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

tweaks in response to comments.

Tue, Jul 16, 12:29 PM · Restricted Project, Restricted Project
ymandel added a comment to D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.

This clearly increases the utility of the library, but also seems to add corner cases that the library won't handle (see the comment about unittests for an example).
WDYT about those? Are they important, should we support producing warnings in those cases to let the users know things might get broken?

Tue, Jul 16, 12:27 PM · Restricted Project, Restricted Project

Wed, Jul 10

ymandel created D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions.
Wed, Jul 10, 10:49 AM · Restricted Project, Restricted Project

Tue, Jul 2

ymandel committed rGe42327566557: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes. (authored by ymandel).
[clang-tidy] Extend TransformerClangTidyCheck to support adding includes.
Tue, Jul 2, 6:26 AM
ymandel committed rL364922: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes..
[clang-tidy] Extend TransformerClangTidyCheck to support adding includes.
Tue, Jul 2, 6:26 AM
ymandel closed D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes..
Tue, Jul 2, 6:26 AM · Restricted Project, Restricted Project
ymandel added inline comments to D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes..
Tue, Jul 2, 6:25 AM · Restricted Project, Restricted Project
ymandel updated the diff for D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes..

switched to llvm::any_of.

Tue, Jul 2, 6:20 AM · Restricted Project, Restricted Project
ymandel committed rG727bdcb23764: [LibTooling] Extend `RewriteRule` with support for adding includes. (authored by ymandel).
[LibTooling] Extend `RewriteRule` with support for adding includes.
Tue, Jul 2, 6:14 AM
ymandel committed rL364917: [LibTooling] Extend `RewriteRule` with support for adding includes..
[LibTooling] Extend `RewriteRule` with support for adding includes.
Tue, Jul 2, 6:13 AM
ymandel closed D63892: [LibTooling] Extend `RewriteRule` with support for adding includes..
Tue, Jul 2, 6:13 AM · Restricted Project, Restricted Project

Mon, Jul 1

ymandel added a comment to D60974: Clang IFSO driver action..

ninja install did the trick. Thanks for your help!

Mon, Jul 1, 1:48 PM · Restricted Project, Restricted Project
ymandel added a comment to D60974: Clang IFSO driver action..

So I think I know what may be going on on your end. The llvm-readelf in your path I believe might be the wrong lllvm-readelf (llvm-readelf-7). Are you sure you built llvm-readelf from git?

Mon, Jul 1, 10:57 AM · Restricted Project, Restricted Project
ymandel added a comment to D60974: Clang IFSO driver action..

The tests for this code are failing in my build. Any suggestions welcome.

Mon, Jul 1, 8:49 AM · Restricted Project, Restricted Project

Fri, Jun 28

ymandel updated the diff for D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes..

Added check for use of AddedIncludes before allocating/registering IncludeInserter.

Fri, Jun 28, 10:00 AM · Restricted Project, Restricted Project
ymandel updated the diff for D63892: [LibTooling] Extend `RewriteRule` with support for adding includes..

comments tweak.

Fri, Jun 28, 9:58 AM · Restricted Project, Restricted Project
ymandel updated the diff for D63892: [LibTooling] Extend `RewriteRule` with support for adding includes..

Responded to comments.

Fri, Jun 28, 9:52 AM · Restricted Project, Restricted Project

Thu, Jun 27

ymandel created D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes..
Thu, Jun 27, 1:20 PM · Restricted Project, Restricted Project
ymandel added a parent revision for D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes.: D63892: [LibTooling] Extend `RewriteRule` with support for adding includes..
Thu, Jun 27, 1:20 PM · Restricted Project, Restricted Project
ymandel added a child revision for D63892: [LibTooling] Extend `RewriteRule` with support for adding includes.: D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes..
Thu, Jun 27, 1:20 PM · Restricted Project, Restricted Project
ymandel created D63892: [LibTooling] Extend `RewriteRule` with support for adding includes..
Thu, Jun 27, 1:15 PM · Restricted Project, Restricted Project

Wed, Jun 26

ymandel committed rG039af0ea03f9: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator. (authored by ymandel).
[clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.
Wed, Jun 26, 9:06 AM
ymandel committed rL364442: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
[clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.
Wed, Jun 26, 9:06 AM
ymandel closed D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Wed, Jun 26, 9:05 AM · Restricted Project, Restricted Project
ymandel committed rG83b1580e1b14: [clang-tidy] Fix ClangTidyTest to initialize context before checks. (authored by ymandel).
[clang-tidy] Fix ClangTidyTest to initialize context before checks.
Wed, Jun 26, 8:06 AM
ymandel committed rL364435: [clang-tidy] Fix ClangTidyTest to initialize context before checks..
[clang-tidy] Fix ClangTidyTest to initialize context before checks.
Wed, Jun 26, 8:04 AM
ymandel closed D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks..
Wed, Jun 26, 8:04 AM · Restricted Project, Restricted Project
ymandel updated the diff for D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..

resp. to comments

Wed, Jun 26, 7:43 AM · Restricted Project, Restricted Project
ymandel added inline comments to D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks..
Wed, Jun 26, 7:43 AM · Restricted Project, Restricted Project
ymandel updated the diff for D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks..

responded to comments.

Wed, Jun 26, 7:39 AM · Restricted Project, Restricted Project

Tue, Jun 25

ymandel added a child revision for D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.: D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Tue, Jun 25, 12:52 PM · Restricted Project, Restricted Project
ymandel added a parent revision for D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.: D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks..
Tue, Jun 25, 12:52 PM · Restricted Project, Restricted Project
ymandel updated the diff for D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..

Rebase onto fix to runCheckOnCode.

Tue, Jun 25, 12:51 PM · Restricted Project, Restricted Project
ymandel created D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks..
Tue, Jun 25, 12:50 PM · Restricted Project, Restricted Project
ymandel added inline comments to D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Tue, Jun 25, 12:06 PM · Restricted Project, Restricted Project
ymandel added inline comments to D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Tue, Jun 25, 11:32 AM · Restricted Project, Restricted Project
ymandel added inline comments to D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Tue, Jun 25, 11:25 AM · Restricted Project, Restricted Project

Mon, Jun 24

ymandel added inline comments to D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Mon, Jun 24, 10:32 AM · Restricted Project, Restricted Project
ymandel updated the diff for D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..

Adjust comments in test.

Mon, Jun 24, 10:32 AM · Restricted Project, Restricted Project
ymandel updated the diff for D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..

Added tests.

Mon, Jun 24, 10:15 AM · Restricted Project, Restricted Project

Jun 13 2019

ymandel committed rG67d4a6d48cf3: [clang-tidy] Make ClangTidyCheck::OptionsView public. (authored by ymandel).
[clang-tidy] Make ClangTidyCheck::OptionsView public.
Jun 13 2019, 12:02 PM
ymandel committed rL363296: [clang-tidy] Make ClangTidyCheck::OptionsView public..
[clang-tidy] Make ClangTidyCheck::OptionsView public.
Jun 13 2019, 12:02 PM
ymandel closed D63287: [clang-tidy] Make ClangTidyCheck::OptionsView public..
Jun 13 2019, 12:01 PM · Restricted Project, Restricted Project
ymandel added a comment to D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..

Thanks for the review!

Jun 13 2019, 11:03 AM · Restricted Project, Restricted Project
ymandel added a child revision for D63287: [clang-tidy] Make ClangTidyCheck::OptionsView public.: D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Jun 13 2019, 10:40 AM · Restricted Project, Restricted Project
ymandel added a parent revision for D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.: D63287: [clang-tidy] Make ClangTidyCheck::OptionsView public..
Jun 13 2019, 10:40 AM · Restricted Project, Restricted Project
ymandel created D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Jun 13 2019, 10:40 AM · Restricted Project, Restricted Project
ymandel created D63287: [clang-tidy] Make ClangTidyCheck::OptionsView public..
Jun 13 2019, 10:33 AM · Restricted Project, Restricted Project

Jun 6 2019

ymandel committed rG2e4a628c06c4: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s. (authored by ymandel).
[LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.
Jun 6 2019, 7:19 AM
ymandel committed rL362707: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s..
[LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.
Jun 6 2019, 7:17 AM
ymandel closed D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s..
Jun 6 2019, 7:17 AM · Restricted Project, Restricted Project

Jun 5 2019

ymandel updated the diff for D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s..

adjusted API comments.

Jun 5 2019, 4:47 AM · Restricted Project, Restricted Project

Jun 4 2019

ymandel added a comment to D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s..

Thanks for the review.

Jun 4 2019, 11:40 AM · Restricted Project, Restricted Project

May 29 2019

ymandel updated the diff for D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s..

added comments.

May 29 2019, 12:45 PM · Restricted Project, Restricted Project
ymandel created D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s..
May 29 2019, 12:36 PM · Restricted Project, Restricted Project
ymandel committed rGe1312c54d3dc: [LibTooling] Add `before` and `after` selectors for selecting point-ranges… (authored by ymandel).
[LibTooling] Add `before` and `after` selectors for selecting point-ranges…
May 29 2019, 5:42 AM
ymandel committed rC361955: [LibTooling] Add `before` and `after` selectors for selecting point-ranges….
[LibTooling] Add `before` and `after` selectors for selecting point-ranges…
May 29 2019, 5:42 AM
ymandel committed rL361955: [LibTooling] Add `before` and `after` selectors for selecting point-ranges….
[LibTooling] Add `before` and `after` selectors for selecting point-ranges…
May 29 2019, 5:42 AM
ymandel closed D62419: [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes..
May 29 2019, 5:42 AM · Restricted Project, Restricted Project

May 24 2019

ymandel updated the summary of D62419: [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes..
May 24 2019, 12:40 PM · Restricted Project, Restricted Project
ymandel created D62419: [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes..
May 24 2019, 12:35 PM · Restricted Project, Restricted Project
ymandel edited projects for D62412: [clang-tidy] Fix unused-variable warning after r361647., added: Restricted Project; removed Restricted Project.
May 24 2019, 11:07 AM · Restricted Project, Restricted Project
ymandel retitled D62412: [clang-tidy] Fix unused-variable warning after r361647. from [LibTooling] Fix unused-variable warning after r361647. to [clang-tidy] Fix unused-variable warning after r361647..
May 24 2019, 11:07 AM · Restricted Project, Restricted Project
ymandel created D62412: [clang-tidy] Fix unused-variable warning after r361647..
May 24 2019, 11:06 AM · Restricted Project, Restricted Project
ymandel committed rG5b33554319cb: [clang-tidy] In TransformerClangTidyCheck, require Explanation field. (authored by ymandel).
[clang-tidy] In TransformerClangTidyCheck, require Explanation field.
May 24 2019, 9:30 AM
ymandel committed rCTE361647: [clang-tidy] In TransformerClangTidyCheck, require Explanation field..
[clang-tidy] In TransformerClangTidyCheck, require Explanation field.
May 24 2019, 9:29 AM
ymandel committed rL361647: [clang-tidy] In TransformerClangTidyCheck, require Explanation field..
[clang-tidy] In TransformerClangTidyCheck, require Explanation field.
May 24 2019, 9:29 AM
ymandel closed D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field..
May 24 2019, 9:29 AM · Restricted Project, Restricted Project
ymandel updated the diff for D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field..

updated to use new version of makeRule; changed explanation text in test

May 24 2019, 8:17 AM · Restricted Project, Restricted Project
ymandel committed rGfab7205ac454: [LibTooling] Add Explanation parameter to `makeRule`. (authored by ymandel).
[LibTooling] Add Explanation parameter to `makeRule`.
May 24 2019, 8:10 AM
ymandel committed rL361643: [LibTooling] Add Explanation parameter to `makeRule`..
[LibTooling] Add Explanation parameter to `makeRule`.
May 24 2019, 8:09 AM
ymandel committed rC361643: [LibTooling] Add Explanation parameter to `makeRule`..
[LibTooling] Add Explanation parameter to `makeRule`.
May 24 2019, 8:09 AM
ymandel closed D62390: [LibTooling] Add Explanation parameter to `makeRule`..
May 24 2019, 8:09 AM · Restricted Project, Restricted Project
ymandel added inline comments to D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field..
May 24 2019, 7:11 AM · Restricted Project, Restricted Project
ymandel created D62390: [LibTooling] Add Explanation parameter to `makeRule`..
May 24 2019, 7:06 AM · Restricted Project, Restricted Project

May 23 2019

ymandel created D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field..
May 23 2019, 12:46 PM · Restricted Project, Restricted Project
ymandel committed rGaa7a2c547e28: [LibTooling] Fix dangling references in RangeSelector. (authored by ymandel).
[LibTooling] Fix dangling references in RangeSelector.
May 23 2019, 10:11 AM
ymandel committed rC361514: [LibTooling] Fix dangling references in RangeSelector..
[LibTooling] Fix dangling references in RangeSelector.
May 23 2019, 10:11 AM
ymandel committed rL361514: [LibTooling] Fix dangling references in RangeSelector..
[LibTooling] Fix dangling references in RangeSelector.
May 23 2019, 10:11 AM
ymandel closed D62328: [LibTooling] Fix dangling references in RangeSelector..
May 23 2019, 10:11 AM · Restricted Project, Restricted Project
ymandel created D62328: [LibTooling] Fix dangling references in RangeSelector..
May 23 2019, 9:11 AM · Restricted Project, Restricted Project
ymandel accepted D62320: Fix LLVM_LINK_LLVM_DYLIB build after rC361285.

Thanks for fixing this. Might want to wait for Nico's response, though, since the original change was at his suggestion.

May 23 2019, 8:04 AM · Restricted Project
ymandel added inline comments to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..
May 23 2019, 5:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project