- User Since
- Sep 27 2018, 12:45 PM (51 w, 3 d)
Fri, Sep 20
converted builders to return optional
reordered tests to match as well.
address comments and some general cleanup
Thanks for the review! Agreed on all points and then some -- next revision will have a bunch of cleanups. I think the only major issue is the return type. See below.
Thu, Sep 19
Added parens operator; cleaned comments and api a bit.
Wed, Sep 18
Tue, Sep 17
Fixed auto use.
Mon, Sep 16
Mon, Sep 9
Fri, Sep 6
Tue, Aug 27
I'm having second thoughts about this -- I prefer the approach I ended up taking in https://reviews.llvm.org/D66676, which is subtly different.
Mon, Aug 26
Aug 23 2019
Aug 14 2019
Aug 13 2019
Aug 12 2019
Changed early return to assertion; updated test.
Bans qualtype and type and adds corresponding comments and test.
I was going to add a test for Type/QualType and realized that they don't carry any source location info. Therefore, I don't think they belong as top-level matchers for rewrite rules. Instead, users should use typeLoc(loc(<type matcher here>). Therefore, the logic of getKind can be eliminated in favor of using K.getSupportedKind() directly. However, that means we'll need to keep them out of the collection of matchers that we're processing.
Aug 9 2019
Rewrote the code and tests.
Thanks for your detailed and helpful feedback.
Aug 8 2019
updated HTML docs.
Thanks for the comments. I struggled with the wording so your edits are appreciated.
Added test; adjusted comments.
Aug 7 2019
Jul 18 2019
remove unneeded include
Moved makeValidRange to its own revision and rebased onto that.
define matcher instead of operator==
Jul 17 2019
Jul 16 2019
tweaks in response to comments.