This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Copy folder without permissions
ClosedPublic

Authored by sebastian-ne on Jul 22 2022, 2:34 AM.

Details

Summary

Copying the folder keeps the original permissions by default. This
creates problems when the source folder is read-only, e.g. in a
packaging environment.
Then, the copied folder in the build directory is read-only as well.
Later on, other files are copied into that directory (in the build
tree), failing when the directory is read-only.

Fix that problem by copying the folder without keeping the original
permissions.

Follow-up to D130254.

Diff Detail

Event Timeline

sebastian-ne created this revision.Jul 22 2022, 2:34 AM
sebastian-ne requested review of this revision.Jul 22 2022, 2:34 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJul 22 2022, 2:34 AM
Ericson2314 accepted this revision.Jul 22 2022, 7:36 AM
This revision is now accepted and ready to land.Jul 22 2022, 7:36 AM
awarzynski accepted this revision.Jul 22 2022, 7:56 AM
This revision was landed with ongoing or failed builds.Jul 25 2022, 1:48 AM
This revision was automatically updated to reflect the committed changes.