This is an archive of the discontinued LLVM Phabricator instance.

Differential D130107

MemoryBuiltins: remove malloc-family funcs from list
ClosedPublic

Authored by durin42 on Jul 19 2022, 11:57 AM.

Details

Reviewers
jdoerfert
sstefan1
nikic
Commits
rG85063090e95f: MemoryBuiltins: remove malloc-family funcs from list
Summary

We no longer need specialized knowledge of these allocator functions in
this file since we have the correct attributes available now.

As far as I can tell the changes in the attributor tests are due to
things getting more consistent on alloc-family once we remove the static
list entries.

The two test changes in NewGVN merit extra scrutiny: NewGVN appears to
be _extremely_ sensitive to the inaccessiblememonly for reasons that
are beyond me. As a result, I had-enumerated all the attributes on
allocation functions in those two tests instead of using -inferattrs.
I assumed that the two -disable-simplify-libcalls tests there no
longer are sensible since the function declaration now includes all the
relevant attributes.

Diff Detail

Unit TestsFailed

TimeTest
60,100 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
30 msx64 debian > LLVM.Analysis/GlobalsModRef::indirect-global.ll
1,960 msx64 debian > LLVM.Examples/OrcV2Examples::lljit-with-remote-debugging.test
1,370 msx64 debian > LLVM.Transforms/Attributor::heap_to_stack.ll
70 msx64 debian > LLVM.Transforms/Attributor::lowerheap.ll
View Full Test Results (46 Failed)

Event Timeline

durin42 created this revision.Jul 19 2022, 11:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2022, 11:57 AM
Herald added subscribers: okura, kuter, hiraditya. · View Herald Transcript
durin42 requested review of this revision.Jul 19 2022, 11:57 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJul 19 2022, 11:57 AM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
durin42 removed a parent revision: D123087: tests: add attributes that would normally come from inferattrs.Jul 19 2022, 11:59 AM
durin42 added a parent revision: D123087: tests: add attributes that would normally come from inferattrs.Jul 19 2022, 12:00 PM
Harbormaster completed remote builds in B176316: Diff 445902.Jul 19 2022, 1:52 PM
durin42 updated this revision to Diff 446195.Jul 20 2022, 9:56 AM
durin42 mentioned this in D130184: BuildLibCalls: move inference of freeing memory later.
durin42 edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B176538: Diff 446195.Jul 20 2022, 9:58 AM
durin42 updated this revision to Diff 446208.Jul 20 2022, 10:35 AM
Harbormaster completed remote builds in B176551: Diff 446208.Jul 20 2022, 11:18 AM
durin42 updated this revision to Diff 446564.Jul 21 2022, 10:24 AM
durin42 edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B176814: Diff 446564.Jul 21 2022, 10:26 AM
durin42 mentioned this in rGbd6aa67e02ef: BuildLibCalls: move inference of freeing memory later.Jul 21 2022, 12:31 PM
nikic mentioned this in D123087: tests: add attributes that would normally come from inferattrs.Jul 22 2022, 1:05 AM
nikic added a subscriber: nikic.Jul 22 2022, 1:09 AM
nikic added inline comments.
llvm/test/Transforms/Attributor/value-simplify-pointer-info.ll
5 ↗(On Diff #446564)

For this test, can we also add explicit attributes instead of running inferattrs?

arichardson added a subscriber: arichardson.Jul 22 2022, 1:42 AM
arichardson added inline comments.
llvm/test/Transforms/NewGVN/calloc-load-removal.ll
18 ↗(On Diff #446564)

Remove?

llvm/test/Transforms/NewGVN/malloc-load-removal.ll
27 ↗(On Diff #446564)

These lines should probably be removed since the RUN line is gone now?

durin42 updated this revision to Diff 447398.Jul 25 2022, 10:20 AM
durin42 marked 3 inline comments as done.Jul 25 2022, 10:20 AM
nikic accepted this revision.Jul 25 2022, 11:47 AM

LGTM

This revision is now accepted and ready to land.Jul 25 2022, 11:47 AM
Harbormaster completed remote builds in B177422: Diff 447398.Jul 25 2022, 11:50 AM
This revision was landed with ongoing or failed builds.Jul 25 2022, 2:29 PM
Closed by commit rG85063090e95f: MemoryBuiltins: remove malloc-family funcs from list (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.
durin42 added a commit: rG85063090e95f: MemoryBuiltins: remove malloc-family funcs from list.
qiongsiwu1 added a subscriber: qiongsiwu1.EditedJul 28 2022, 7:00 AM

May I ask for some guidance/example on how to use the attributes to identify that the removed functions (e.g. malloc, calloc, realloc) are still allocation functions?

Is it true that bool llvm::isAllocationFn returns false now if the input is a malloc call? It seems to be so in my experiments. Is this intended? This is contradictory to the code comment .

Additionally, what is the recommended approach now to tell if a library function allocates memory? It seems that bool llvm::isAllocationFn is covering some functions (ones still included in the list AllocationFnData), but not others (ones this patch removed). When should we use bool llvm::isAllocationFn? Or should we migrate to use attributes and avoid using bool llvm::isAllocationFn?

Thanks so much!!

durin42 added a comment.Jul 28 2022, 7:09 AM
In D130107#3684978, @qiongsiwu1 wrote:

May I ask for some guidance/example on how to use the attributes to identify that the removed functions (e.g. malloc, calloc, realloc) are still allocation functions?

Is it true that bool llvm::isAllocationFn returns false now if the input is a malloc call? It seems to be so in my experiments. Is this intended? This is contradictory to the code comment .

If the function isn't annotated with the right attributes, it won't be understood to be an allocation function unless it's in the big static list in MemoryBuiltins. There were a series of changes to BuildLibCalls (eg D123089) which mean that the -inferattrs pass will insert the right attributes on your function declarations, so you may just need an extra pass for that to work, or to add the attributes manually in your test case if you don't want to run attribute inference.

Additionally, what is the recommended approach now to tell if a library function allocates memory? It seems that bool llvm::isAllocationFn is covering some functions (ones still included in the list AllocationFnData), but not others (ones this patch removed). When should we use bool llvm::isAllocationFn? Or should we migrate to use attributes and avoid using bool llvm::isAllocationFn?

I'd still use isAllocationFn - that checks both the static list and the attributes. If we ever manage to get the list to empty, that should still work.

Does that help?

qiongsiwu1 added a comment.EditedJul 28 2022, 7:37 AM

Does that help?

Yes! I am trying out the inferattrs pass. Still having some test failures but as you mentioned the tests most likely need some tuning.

Thanks for the fast response!

Revision Contents

PathSize
llvm/
lib/
Analysis/
7 lines
test/
Transforms/
Attributor/
105 lines

Diff 445902

llvm/lib/Analysis/MemoryBuiltins.cpp

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Linesstruct AllocFnsTy {
// Name of default allocator function to group malloc/free calls by family // Name of default allocator function to group malloc/free calls by family
MallocFamily Family; MallocFamily Family;
}; };
// clang-format off // clang-format off
// FIXME: certain users need more information. E.g., SimplifyLibCalls needs to // FIXME: certain users need more information. E.g., SimplifyLibCalls needs to
// know which functions are nounwind, noalias, nocapture parameters, etc. // know which functions are nounwind, noalias, nocapture parameters, etc.
static const std::pair<LibFunc, AllocFnsTy> AllocationFnData[] = { static const std::pair<LibFunc, AllocFnsTy> AllocationFnData[] = {
{LibFunc_malloc, {MallocLike, 1, 0, -1, -1, MallocFamily::Malloc}},
{LibFunc_vec_malloc, {MallocLike, 1, 0, -1, -1, MallocFamily::VecMalloc}}, {LibFunc_vec_malloc, {MallocLike, 1, 0, -1, -1, MallocFamily::VecMalloc}},
{LibFunc_valloc, {MallocLike, 1, 0, -1, -1, MallocFamily::Malloc}},
{LibFunc_Znwj, {OpNewLike, 1, 0, -1, -1, MallocFamily::CPPNew}}, // new(unsigned int) {LibFunc_Znwj, {OpNewLike, 1, 0, -1, -1, MallocFamily::CPPNew}}, // new(unsigned int)
{LibFunc_ZnwjRKSt9nothrow_t, {MallocLike, 2, 0, -1, -1, MallocFamily::CPPNew}}, // new(unsigned int, nothrow) {LibFunc_ZnwjRKSt9nothrow_t, {MallocLike, 2, 0, -1, -1, MallocFamily::CPPNew}}, // new(unsigned int, nothrow)
{LibFunc_ZnwjSt11align_val_t, {OpNewLike, 2, 0, -1, 1, MallocFamily::CPPNewAligned}}, // new(unsigned int, align_val_t) {LibFunc_ZnwjSt11align_val_t, {OpNewLike, 2, 0, -1, 1, MallocFamily::CPPNewAligned}}, // new(unsigned int, align_val_t)
{LibFunc_ZnwjSt11align_val_tRKSt9nothrow_t, {MallocLike, 3, 0, -1, 1, MallocFamily::CPPNewAligned}}, // new(unsigned int, align_val_t, nothrow) {LibFunc_ZnwjSt11align_val_tRKSt9nothrow_t, {MallocLike, 3, 0, -1, 1, MallocFamily::CPPNewAligned}}, // new(unsigned int, align_val_t, nothrow)
{LibFunc_Znwm, {OpNewLike, 1, 0, -1, -1, MallocFamily::CPPNew}}, // new(unsigned long) {LibFunc_Znwm, {OpNewLike, 1, 0, -1, -1, MallocFamily::CPPNew}}, // new(unsigned long)
{LibFunc_ZnwmRKSt9nothrow_t, {MallocLike, 2, 0, -1, -1, MallocFamily::CPPNew}}, // new(unsigned long, nothrow) {LibFunc_ZnwmRKSt9nothrow_t, {MallocLike, 2, 0, -1, -1, MallocFamily::CPPNew}}, // new(unsigned long, nothrow)
{LibFunc_ZnwmSt11align_val_t, {OpNewLike, 2, 0, -1, 1, MallocFamily::CPPNewAligned}}, // new(unsigned long, align_val_t) {LibFunc_ZnwmSt11align_val_t, {OpNewLike, 2, 0, -1, 1, MallocFamily::CPPNewAligned}}, // new(unsigned long, align_val_t)
{LibFunc_ZnwmSt11align_val_tRKSt9nothrow_t, {MallocLike, 3, 0, -1, 1, MallocFamily::CPPNewAligned}}, // new(unsigned long, align_val_t, nothrow) {LibFunc_ZnwmSt11align_val_tRKSt9nothrow_t, {MallocLike, 3, 0, -1, 1, MallocFamily::CPPNewAligned}}, // new(unsigned long, align_val_t, nothrow)
{LibFunc_Znaj, {OpNewLike, 1, 0, -1, -1, MallocFamily::CPPNewArray}}, // new[](unsigned int) {LibFunc_Znaj, {OpNewLike, 1, 0, -1, -1, MallocFamily::CPPNewArray}}, // new[](unsigned int)
{LibFunc_ZnajRKSt9nothrow_t, {MallocLike, 2, 0, -1, -1, MallocFamily::CPPNewArray}}, // new[](unsigned int, nothrow) {LibFunc_ZnajRKSt9nothrow_t, {MallocLike, 2, 0, -1, -1, MallocFamily::CPPNewArray}}, // new[](unsigned int, nothrow)
{LibFunc_ZnajSt11align_val_t, {OpNewLike, 2, 0, -1, 1, MallocFamily::CPPNewArrayAligned}}, // new[](unsigned int, align_val_t) {LibFunc_ZnajSt11align_val_t, {OpNewLike, 2, 0, -1, 1, MallocFamily::CPPNewArrayAligned}}, // new[](unsigned int, align_val_t)
{LibFunc_ZnajSt11align_val_tRKSt9nothrow_t, {MallocLike, 3, 0, -1, 1, MallocFamily::CPPNewArrayAligned}}, // new[](unsigned int, align_val_t, nothrow) {LibFunc_ZnajSt11align_val_tRKSt9nothrow_t, {MallocLike, 3, 0, -1, 1, MallocFamily::CPPNewArrayAligned}}, // new[](unsigned int, align_val_t, nothrow)
{LibFunc_Znam, {OpNewLike, 1, 0, -1, -1, MallocFamily::CPPNewArray}}, // new[](unsigned long) {LibFunc_Znam, {OpNewLike, 1, 0, -1, -1, MallocFamily::CPPNewArray}}, // new[](unsigned long)
{LibFunc_ZnamRKSt9nothrow_t, {MallocLike, 2, 0, -1, -1, MallocFamily::CPPNewArray}}, // new[](unsigned long, nothrow) {LibFunc_ZnamRKSt9nothrow_t, {MallocLike, 2, 0, -1, -1, MallocFamily::CPPNewArray}}, // new[](unsigned long, nothrow)
{LibFunc_ZnamSt11align_val_t, {OpNewLike, 2, 0, -1, 1, MallocFamily::CPPNewArrayAligned}}, // new[](unsigned long, align_val_t) {LibFunc_ZnamSt11align_val_t, {OpNewLike, 2, 0, -1, 1, MallocFamily::CPPNewArrayAligned}}, // new[](unsigned long, align_val_t)
{LibFunc_ZnamSt11align_val_tRKSt9nothrow_t, {MallocLike, 3, 0, -1, 1, MallocFamily::CPPNewArrayAligned}}, // new[](unsigned long, align_val_t, nothrow) {LibFunc_ZnamSt11align_val_tRKSt9nothrow_t, {MallocLike, 3, 0, -1, 1, MallocFamily::CPPNewArrayAligned}}, // new[](unsigned long, align_val_t, nothrow)
{LibFunc_msvc_new_int, {OpNewLike, 1, 0, -1, -1, MallocFamily::MSVCNew}}, // new(unsigned int) {LibFunc_msvc_new_int, {OpNewLike, 1, 0, -1, -1, MallocFamily::MSVCNew}}, // new(unsigned int)
{LibFunc_msvc_new_int_nothrow, {MallocLike, 2, 0, -1, -1, MallocFamily::MSVCNew}}, // new(unsigned int, nothrow) {LibFunc_msvc_new_int_nothrow, {MallocLike, 2, 0, -1, -1, MallocFamily::MSVCNew}}, // new(unsigned int, nothrow)
{LibFunc_msvc_new_longlong, {OpNewLike, 1, 0, -1, -1, MallocFamily::MSVCNew}}, // new(unsigned long long) {LibFunc_msvc_new_longlong, {OpNewLike, 1, 0, -1, -1, MallocFamily::MSVCNew}}, // new(unsigned long long)
{LibFunc_msvc_new_longlong_nothrow, {MallocLike, 2, 0, -1, -1, MallocFamily::MSVCNew}}, // new(unsigned long long, nothrow) {LibFunc_msvc_new_longlong_nothrow, {MallocLike, 2, 0, -1, -1, MallocFamily::MSVCNew}}, // new(unsigned long long, nothrow)
{LibFunc_msvc_new_array_int, {OpNewLike, 1, 0, -1, -1, MallocFamily::MSVCArrayNew}}, // new[](unsigned int) {LibFunc_msvc_new_array_int, {OpNewLike, 1, 0, -1, -1, MallocFamily::MSVCArrayNew}}, // new[](unsigned int)
{LibFunc_msvc_new_array_int_nothrow, {MallocLike, 2, 0, -1, -1, MallocFamily::MSVCArrayNew}}, // new[](unsigned int, nothrow) {LibFunc_msvc_new_array_int_nothrow, {MallocLike, 2, 0, -1, -1, MallocFamily::MSVCArrayNew}}, // new[](unsigned int, nothrow)
{LibFunc_msvc_new_array_longlong, {OpNewLike, 1, 0, -1, -1, MallocFamily::MSVCArrayNew}}, // new[](unsigned long long) {LibFunc_msvc_new_array_longlong, {OpNewLike, 1, 0, -1, -1, MallocFamily::MSVCArrayNew}}, // new[](unsigned long long)
{LibFunc_msvc_new_array_longlong_nothrow, {MallocLike, 2, 0, -1, -1, MallocFamily::MSVCArrayNew}}, // new[](unsigned long long, nothrow) {LibFunc_msvc_new_array_longlong_nothrow, {MallocLike, 2, 0, -1, -1, MallocFamily::MSVCArrayNew}}, // new[](unsigned long long, nothrow)
{LibFunc_aligned_alloc, {AlignedAllocLike, 2, 1, -1, 0, MallocFamily::Malloc}},
{LibFunc_memalign, {AlignedAllocLike, 2, 1, -1, 0, MallocFamily::Malloc}}, {LibFunc_memalign, {AlignedAllocLike, 2, 1, -1, 0, MallocFamily::Malloc}},
{LibFunc_calloc, {CallocLike, 2, 0, 1, -1, MallocFamily::Malloc}},
{LibFunc_vec_calloc, {CallocLike, 2, 0, 1, -1, MallocFamily::VecMalloc}}, {LibFunc_vec_calloc, {CallocLike, 2, 0, 1, -1, MallocFamily::VecMalloc}},
{LibFunc_realloc, {ReallocLike, 2, 1, -1, -1, MallocFamily::Malloc}},
{LibFunc_vec_realloc, {ReallocLike, 2, 1, -1, -1, MallocFamily::VecMalloc}}, {LibFunc_vec_realloc, {ReallocLike, 2, 1, -1, -1, MallocFamily::VecMalloc}},
{LibFunc_reallocf, {ReallocLike, 2, 1, -1, -1, MallocFamily::Malloc}},
{LibFunc_strdup, {StrDupLike, 1, -1, -1, -1, MallocFamily::Malloc}}, {LibFunc_strdup, {StrDupLike, 1, -1, -1, -1, MallocFamily::Malloc}},
{LibFunc_dunder_strdup, {StrDupLike, 1, -1, -1, -1, MallocFamily::Malloc}}, {LibFunc_dunder_strdup, {StrDupLike, 1, -1, -1, -1, MallocFamily::Malloc}},
{LibFunc_strndup, {StrDupLike, 2, 1, -1, -1, MallocFamily::Malloc}}, {LibFunc_strndup, {StrDupLike, 2, 1, -1, -1, MallocFamily::Malloc}},
{LibFunc_dunder_strndup, {StrDupLike, 2, 1, -1, -1, MallocFamily::Malloc}}, {LibFunc_dunder_strndup, {StrDupLike, 2, 1, -1, -1, MallocFamily::Malloc}},
{LibFunc___kmpc_alloc_shared, {MallocLike, 1, 0, -1, -1, MallocFamily::KmpcAllocShared}}, {LibFunc___kmpc_alloc_shared, {MallocLike, 1, 0, -1, -1, MallocFamily::KmpcAllocShared}},
}; };
// clang-format on // clang-format on
▲ Show 20 Lines • Show All 315 Lines • ▼ Show 20 Lines
struct FreeFnsTy { struct FreeFnsTy {
unsigned NumParams; unsigned NumParams;
// Name of default allocator function to group malloc/free calls by family // Name of default allocator function to group malloc/free calls by family
MallocFamily Family; MallocFamily Family;
}; };
// clang-format off // clang-format off
static const std::pair<LibFunc, FreeFnsTy> FreeFnData[] = { static const std::pair<LibFunc, FreeFnsTy> FreeFnData[] = {
{LibFunc_free, {1, MallocFamily::Malloc}},
{LibFunc_vec_free, {1, MallocFamily::VecMalloc}}, {LibFunc_vec_free, {1, MallocFamily::VecMalloc}},
{LibFunc_ZdlPv, {1, MallocFamily::CPPNew}}, // operator delete(void*) {LibFunc_ZdlPv, {1, MallocFamily::CPPNew}}, // operator delete(void*)
{LibFunc_ZdaPv, {1, MallocFamily::CPPNewArray}}, // operator delete[](void*) {LibFunc_ZdaPv, {1, MallocFamily::CPPNewArray}}, // operator delete[](void*)
{LibFunc_msvc_delete_ptr32, {1, MallocFamily::MSVCNew}}, // operator delete(void*) {LibFunc_msvc_delete_ptr32, {1, MallocFamily::MSVCNew}}, // operator delete(void*)
{LibFunc_msvc_delete_ptr64, {1, MallocFamily::MSVCNew}}, // operator delete(void*) {LibFunc_msvc_delete_ptr64, {1, MallocFamily::MSVCNew}}, // operator delete(void*)
{LibFunc_msvc_delete_array_ptr32, {1, MallocFamily::MSVCArrayNew}}, // operator delete[](void*) {LibFunc_msvc_delete_array_ptr32, {1, MallocFamily::MSVCArrayNew}}, // operator delete[](void*)
{LibFunc_msvc_delete_array_ptr64, {1, MallocFamily::MSVCArrayNew}}, // operator delete[](void*) {LibFunc_msvc_delete_array_ptr64, {1, MallocFamily::MSVCArrayNew}}, // operator delete[](void*)
{LibFunc_ZdlPvj, {2, MallocFamily::CPPNew}}, // delete(void*, uint) {LibFunc_ZdlPvj, {2, MallocFamily::CPPNew}}, // delete(void*, uint)
▲ Show 20 Lines • Show All 787 Lines • Show Last 20 Lines

llvm/test/Transforms/Attributor/heap_to_stack.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals
; RUN: opt -attributor -enable-new-pm=0 -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=5 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_NPM,NOT_CGSCC_OPM,NOT_TUNIT_NPM,IS__TUNIT____,IS________OPM,IS__TUNIT_OPM ; RUN: opt -attributor -enable-new-pm=0 -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=8 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_NPM,NOT_CGSCC_OPM,NOT_TUNIT_NPM,IS__TUNIT____,IS________OPM,IS__TUNIT_OPM
; RUN: opt -aa-pipeline=basic-aa -passes=attributor -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=8 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_OPM,NOT_CGSCC_NPM,NOT_TUNIT_OPM,IS__TUNIT____,IS________NPM,IS__TUNIT_NPM ; RUN: opt -aa-pipeline=basic-aa -passes=attributor -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=8 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_OPM,NOT_CGSCC_NPM,NOT_TUNIT_OPM,IS__TUNIT____,IS________NPM,IS__TUNIT_NPM
; RUN: opt -attributor-cgscc -enable-new-pm=0 -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_NPM,IS__CGSCC____,IS________OPM,IS__CGSCC_OPM ; RUN: opt -attributor-cgscc -enable-new-pm=0 -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_NPM,IS__CGSCC____,IS________OPM,IS__CGSCC_OPM
; RUN: opt -aa-pipeline=basic-aa -passes=attributor-cgscc -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_OPM,IS__CGSCC____,IS________NPM,IS__CGSCC_NPM ; RUN: opt -aa-pipeline=basic-aa -passes=attributor-cgscc -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_OPM,IS__CGSCC____,IS________NPM,IS__CGSCC_NPM
declare noalias i8* @malloc(i64) allockind("alloc,uninitialized") allocsize(0) declare noalias i8* @malloc(i64) allockind("alloc,uninitialized") allocsize(0)
declare void @nocapture_func_frees_pointer(i8* nocapture) declare void @nocapture_func_frees_pointer(i8* nocapture)
Show All 18 Lines
declare void @free(i8* nocapture) allockind("free") declare void @free(i8* nocapture) allockind("free")
declare void @llvm.lifetime.start.p0i8(i64, i8* nocapture) nounwind declare void @llvm.lifetime.start.p0i8(i64, i8* nocapture) nounwind
define void @h2s_value_simplify_interaction(i1 %c, i8* %A) { define void @h2s_value_simplify_interaction(i1 %c, i8* %A) {
; IS________OPM-LABEL: define {{[^@]+}}@h2s_value_simplify_interaction ; IS________OPM-LABEL: define {{[^@]+}}@h2s_value_simplify_interaction
; IS________OPM-SAME: (i1 [[C:%.*]], i8* nocapture nofree readnone [[A:%.*]]) { ; IS________OPM-SAME: (i1 [[C:%.*]], i8* nocapture nofree readnone [[A:%.*]]) {
; IS________OPM-NEXT: entry: ; IS________OPM-NEXT: entry:
; IS________OPM-NEXT: [[M:%.*]] = tail call noalias align 16 i8* @malloc(i64 noundef 4) ; IS________OPM-NEXT: [[M_H2S:%.*]] = alloca i8, i64 4, align 16
; IS________OPM-NEXT: br i1 [[C]], label [[T:%.*]], label [[F:%.*]] ; IS________OPM-NEXT: br i1 [[C]], label [[T:%.*]], label [[F:%.*]]
; IS________OPM: t: ; IS________OPM: t:
; IS________OPM-NEXT: br i1 false, label [[DEAD:%.*]], label [[F2:%.*]] ; IS________OPM-NEXT: br i1 false, label [[DEAD:%.*]], label [[F2:%.*]]
; IS________OPM: f: ; IS________OPM: f:
; IS________OPM-NEXT: br label [[J:%.*]] ; IS________OPM-NEXT: br label [[J:%.*]]
; IS________OPM: f2: ; IS________OPM: f2:
; IS________OPM-NEXT: [[C1:%.*]] = bitcast i8* [[M]] to i32* ; IS________OPM-NEXT: [[C1:%.*]] = bitcast i8* [[M_H2S]] to i32*
; IS________OPM-NEXT: [[C2:%.*]] = bitcast i32* [[C1]] to i8* ; IS________OPM-NEXT: [[C2:%.*]] = bitcast i32* [[C1]] to i8*
; IS________OPM-NEXT: [[L:%.*]] = load i8, i8* [[C2]], align 16 ; IS________OPM-NEXT: [[L:%.*]] = load i8, i8* [[C2]], align 16
; IS________OPM-NEXT: call void @usei8(i8 [[L]]) ; IS________OPM-NEXT: call void @usei8(i8 [[L]])
; IS________OPM-NEXT: call void @no_sync_func(i8* nocapture nofree noundef align 16 [[C2]]) #[[ATTR9:[0-9]+]] ; IS________OPM-NEXT: call void @no_sync_func(i8* nocapture nofree noundef align 16 [[C2]]) #[[ATTR9:[0-9]+]]
; IS________OPM-NEXT: br label [[J]] ; IS________OPM-NEXT: br label [[J]]
; IS________OPM: dead: ; IS________OPM: dead:
; IS________OPM-NEXT: unreachable ; IS________OPM-NEXT: unreachable
; IS________OPM: j: ; IS________OPM: j:
▲ Show 20 Lines • Show All 137 Lines • ▼ Show 20 Lines
; IS________OPM-SAME: (i8* nocapture [[P:%.*]]) { ; IS________OPM-SAME: (i8* nocapture [[P:%.*]]) {
; IS________OPM-NEXT: [[TMP1:%.*]] = tail call noalias i8* @aligned_alloc(i64 noundef 32, i64 noundef 128) ; IS________OPM-NEXT: [[TMP1:%.*]] = tail call noalias i8* @aligned_alloc(i64 noundef 32, i64 noundef 128)
; IS________OPM-NEXT: tail call void @nofree_arg_only(i8* nocapture nofree [[TMP1]], i8* nocapture [[P]]) ; IS________OPM-NEXT: tail call void @nofree_arg_only(i8* nocapture nofree [[TMP1]], i8* nocapture [[P]])
; IS________OPM-NEXT: tail call void @free(i8* noalias nocapture [[TMP1]]) ; IS________OPM-NEXT: tail call void @free(i8* noalias nocapture [[TMP1]])
; IS________OPM-NEXT: ret void ; IS________OPM-NEXT: ret void
; ;
; IS________NPM-LABEL: define {{[^@]+}}@test3b ; IS________NPM-LABEL: define {{[^@]+}}@test3b
; IS________NPM-SAME: (i8* nocapture [[P:%.*]]) { ; IS________NPM-SAME: (i8* nocapture [[P:%.*]]) {
; IS________NPM-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 128, align 32 ; IS________NPM-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 128, align 1
; IS________NPM-NEXT: tail call void @nofree_arg_only(i8* noalias nocapture nofree [[DOTH2S]], i8* nocapture [[P]]) ; IS________NPM-NEXT: tail call void @nofree_arg_only(i8* noalias nocapture nofree [[DOTH2S]], i8* nocapture [[P]])
; IS________NPM-NEXT: ret void ; IS________NPM-NEXT: ret void
; ;
%1 = tail call noalias i8* @aligned_alloc(i64 32, i64 128) %1 = tail call noalias i8* @aligned_alloc(i64 32, i64 128)
tail call void @nofree_arg_only(i8* %1, i8* %p) tail call void @nofree_arg_only(i8* %1, i8* %p)
tail call void @free(i8* %1) tail call void @free(i8* %1)
ret void ret void
} }
; leave alone non-constant alignments. ; leave alone non-constant alignments.
define void @test3c(i64 %alignment) { define void @test3c(i64 %alignment) {
; CHECK-LABEL: define {{[^@]+}}@test3c ; IS________OPM-LABEL: define {{[^@]+}}@test3c
; CHECK-SAME: (i64 [[ALIGNMENT:%.*]]) { ; IS________OPM-SAME: (i64 [[ALIGNMENT:%.*]]) {
; CHECK-NEXT: [[TMP1:%.*]] = tail call noalias i8* @aligned_alloc(i64 [[ALIGNMENT]], i64 noundef 128) ; IS________OPM-NEXT: [[TMP1:%.*]] = tail call noalias i8* @aligned_alloc(i64 [[ALIGNMENT]], i64 noundef 128)
; CHECK-NEXT: tail call void @free(i8* noalias nocapture [[TMP1]]) ; IS________OPM-NEXT: tail call void @free(i8* noalias nocapture [[TMP1]])
; CHECK-NEXT: ret void ; IS________OPM-NEXT: ret void
;
; IS________NPM-LABEL: define {{[^@]+}}@test3c
; IS________NPM-SAME: (i64 [[ALIGNMENT:%.*]]) {
; IS________NPM-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 128, align 1
; IS________NPM-NEXT: ret void
; ;
%1 = tail call noalias i8* @aligned_alloc(i64 %alignment, i64 128) %1 = tail call noalias i8* @aligned_alloc(i64 %alignment, i64 128)
tail call void @free(i8* %1) tail call void @free(i8* %1)
ret void ret void
} }
; leave alone a constant-but-invalid alignment ; leave alone a constant-but-invalid alignment
define void @test3d(i8* %p) { define void @test3d(i8* %p) {
; IS________OPM-LABEL: define {{[^@]+}}@test3d ; IS________OPM-LABEL: define {{[^@]+}}@test3d
; IS________OPM-SAME: (i8* nocapture [[P:%.*]]) { ; IS________OPM-SAME: (i8* nocapture [[P:%.*]]) {
; IS________OPM-NEXT: [[TMP1:%.*]] = tail call noalias i8* @aligned_alloc(i64 noundef 33, i64 noundef 128) ; IS________OPM-NEXT: [[TMP1:%.*]] = tail call noalias i8* @aligned_alloc(i64 noundef 33, i64 noundef 128)
; IS________OPM-NEXT: tail call void @nofree_arg_only(i8* nocapture nofree [[TMP1]], i8* nocapture [[P]]) ; IS________OPM-NEXT: tail call void @nofree_arg_only(i8* nocapture nofree [[TMP1]], i8* nocapture [[P]])
; IS________OPM-NEXT: tail call void @free(i8* noalias nocapture [[TMP1]]) ; IS________OPM-NEXT: tail call void @free(i8* noalias nocapture [[TMP1]])
; IS________OPM-NEXT: ret void ; IS________OPM-NEXT: ret void
; ;
; IS________NPM-LABEL: define {{[^@]+}}@test3d ; IS________NPM-LABEL: define {{[^@]+}}@test3d
; IS________NPM-SAME: (i8* nocapture [[P:%.*]]) { ; IS________NPM-SAME: (i8* nocapture [[P:%.*]]) {
; IS________NPM-NEXT: [[TMP1:%.*]] = tail call noalias i8* @aligned_alloc(i64 noundef 33, i64 noundef 128) ; IS________NPM-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 128, align 1
; IS________NPM-NEXT: tail call void @nofree_arg_only(i8* noalias nocapture nofree [[TMP1]], i8* nocapture [[P]]) ; IS________NPM-NEXT: tail call void @nofree_arg_only(i8* noalias nocapture nofree [[DOTH2S]], i8* nocapture [[P]])
; IS________NPM-NEXT: tail call void @free(i8* noalias nocapture [[TMP1]])
; IS________NPM-NEXT: ret void ; IS________NPM-NEXT: ret void
; ;
; CHECK-SAME; (i8* nocapture [[P:%.*]]) { ; CHECK-SAME; (i8* nocapture [[P:%.*]]) {
%1 = tail call noalias i8* @aligned_alloc(i64 33, i64 128) %1 = tail call noalias i8* @aligned_alloc(i64 33, i64 128)
tail call void @nofree_arg_only(i8* %1, i8* %p) tail call void @nofree_arg_only(i8* %1, i8* %p)
tail call void @free(i8* %1) tail call void @free(i8* %1)
ret void ret void
} }
Show All 16 Lines;
%1 = tail call noalias i8* @calloc(i64 2, i64 4) %1 = tail call noalias i8* @calloc(i64 2, i64 4)
tail call void @no_sync_func(i8* %1) tail call void @no_sync_func(i8* %1)
tail call void @free(i8* %1) tail call void @free(i8* %1)
ret void ret void
} }
; TEST 4 ; TEST 4
define void @test4() { define void @test4() {
; IS________OPM-LABEL: define {{[^@]+}}@test4() { ; CHECK-LABEL: define {{[^@]+}}@test4() {
; IS________OPM-NEXT: [[TMP1:%.*]] = tail call noalias i8* @malloc(i64 noundef 4) ; CHECK-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 4, align 1
; IS________OPM-NEXT: tail call void @nofree_func(i8* noalias nocapture nofree [[TMP1]]) ; CHECK-NEXT: tail call void @nofree_func(i8* noalias nocapture nofree [[DOTH2S]])
; IS________OPM-NEXT: ret void ; CHECK-NEXT: ret void
;
; IS________NPM-LABEL: define {{[^@]+}}@test4() {
; IS________NPM-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 4, align 1
; IS________NPM-NEXT: tail call void @nofree_func(i8* noalias nocapture nofree [[DOTH2S]])
; IS________NPM-NEXT: ret void
; ;
%1 = tail call noalias i8* @malloc(i64 4) %1 = tail call noalias i8* @malloc(i64 4)
tail call void @nofree_func(i8* %1) tail call void @nofree_func(i8* %1)
ret void ret void
} }
; TEST 5 - not all exit paths have a call to free, but all uses of malloc ; TEST 5 - not all exit paths have a call to free, but all uses of malloc
; are in nofree functions and are not captured ; are in nofree functions and are not captured
▲ Show 20 Lines • Show All 266 Lines • ▼ Show 20 Lines
; IS________OPM-NEXT: br i1 [[TMP11]], label [[TMP12:%.*]], label [[TMP15:%.*]] ; IS________OPM-NEXT: br i1 [[TMP11]], label [[TMP12:%.*]], label [[TMP15:%.*]]
; IS________OPM: 12: ; IS________OPM: 12:
; IS________OPM-NEXT: br label [[TMP13]] ; IS________OPM-NEXT: br label [[TMP13]]
; IS________OPM: 13: ; IS________OPM: 13:
; IS________OPM-NEXT: [[DOT1:%.*]] = phi i32 [ [[TMP6]], [[TMP5]] ], [ [[DOT0]], [[TMP12]] ] ; IS________OPM-NEXT: [[DOT1:%.*]] = phi i32 [ [[TMP6]], [[TMP5]] ], [ [[DOT0]], [[TMP12]] ]
; IS________OPM-NEXT: [[TMP14]] = add nsw i32 [[DOT1]], 1 ; IS________OPM-NEXT: [[TMP14]] = add nsw i32 [[DOT1]], 1
; IS________OPM-NEXT: br label [[TMP8]] ; IS________OPM-NEXT: br label [[TMP8]]
; IS________OPM: 15: ; IS________OPM: 15:
; IS________OPM-NEXT: [[TMP16:%.*]] = load i32, i32* [[TMP3]], align 4 ; IS________OPM-NEXT: [[TMP16:%.*]] = bitcast i32* [[TMP3]] to i8*
; IS________OPM-NEXT: [[TMP17:%.*]] = bitcast i32* [[TMP3]] to i8* ; IS________OPM-NEXT: call void @free(i8* nocapture noundef [[TMP16]])
; IS________OPM-NEXT: call void @free(i8* nocapture noundef [[TMP17]]) ; IS________OPM-NEXT: [[TMP17:%.*]] = load i32, i32* [[TMP3]], align 4
; IS________OPM-NEXT: [[TMP18:%.*]] = load i32, i32* [[TMP3]], align 4 ; IS________OPM-NEXT: ret i32 [[TMP17]]
; IS________OPM-NEXT: ret i32 [[TMP18]]
; ;
; IS________NPM-LABEL: define {{[^@]+}}@irreducible_cfg ; IS________NPM-LABEL: define {{[^@]+}}@irreducible_cfg
; IS________NPM-SAME: (i32 [[TMP0:%.*]]) { ; IS________NPM-SAME: (i32 [[TMP0:%.*]]) {
; IS________NPM-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 4, align 1 ; IS________NPM-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 4, align 1
; IS________NPM-NEXT: [[TMP2:%.*]] = bitcast i8* [[DOTH2S]] to i32* ; IS________NPM-NEXT: [[TMP2:%.*]] = bitcast i8* [[DOTH2S]] to i32*
; IS________NPM-NEXT: store i32 10, i32* [[TMP2]], align 4 ; IS________NPM-NEXT: store i32 10, i32* [[TMP2]], align 4
; IS________NPM-NEXT: [[TMP3:%.*]] = icmp eq i32 [[TMP0]], 1 ; IS________NPM-NEXT: [[TMP3:%.*]] = icmp eq i32 [[TMP0]], 1
; IS________NPM-NEXT: br i1 [[TMP3]], label [[TMP4:%.*]], label [[TMP6:%.*]] ; IS________NPM-NEXT: br i1 [[TMP3]], label [[TMP4:%.*]], label [[TMP6:%.*]]
▲ Show 20 Lines • Show All 54 Lines • ▼ Show 20 Lines15: ; preds = %8
%17 = bitcast i32* %3 to i8* %17 = bitcast i32* %3 to i8*
call void @free(i8* %17) call void @free(i8* %17)
%18 = load i32, i32* %3, align 4 %18 = load i32, i32* %3, align 4
ret i32 %18 ret i32 %18
} }
define i32 @malloc_in_loop(i32 %0) { define i32 @malloc_in_loop(i32 %0) {
; IS________OPM-LABEL: define {{[^@]+}}@malloc_in_loop ; CHECK-LABEL: define {{[^@]+}}@malloc_in_loop
; IS________OPM-SAME: (i32 [[TMP0:%.*]]) { ; CHECK-SAME: (i32 [[TMP0:%.*]]) {
; IS________OPM-NEXT: [[TMP2:%.*]] = alloca i32, align 4 ; CHECK-NEXT: [[TMP2:%.*]] = alloca i32, align 4
; IS________OPM-NEXT: [[TMP3:%.*]] = alloca i32*, align 8 ; CHECK-NEXT: [[TMP3:%.*]] = alloca i32*, align 8
; IS________OPM-NEXT: store i32 [[TMP0]], i32* [[TMP2]], align 4 ; CHECK-NEXT: store i32 [[TMP0]], i32* [[TMP2]], align 4
; IS________OPM-NEXT: br label [[TMP4:%.*]] ; CHECK-NEXT: br label [[TMP4:%.*]]
; IS________OPM: 4: ; CHECK: 4:
; IS________OPM-NEXT: [[TMP5:%.*]] = load i32, i32* [[TMP2]], align 4 ; CHECK-NEXT: [[TMP5:%.*]] = load i32, i32* [[TMP2]], align 4
; IS________OPM-NEXT: [[TMP6:%.*]] = add nsw i32 [[TMP5]], -1 ; CHECK-NEXT: [[TMP6:%.*]] = add nsw i32 [[TMP5]], -1
; IS________OPM-NEXT: store i32 [[TMP6]], i32* [[TMP2]], align 4 ; CHECK-NEXT: store i32 [[TMP6]], i32* [[TMP2]], align 4
; IS________OPM-NEXT: [[TMP7:%.*]] = icmp sgt i32 [[TMP6]], 0 ; CHECK-NEXT: [[TMP7:%.*]] = icmp sgt i32 [[TMP6]], 0
; IS________OPM-NEXT: br i1 [[TMP7]], label [[TMP8:%.*]], label [[TMP11:%.*]] ; CHECK-NEXT: br i1 [[TMP7]], label [[TMP8:%.*]], label [[TMP10:%.*]]
; IS________OPM: 8: ; CHECK: 8:
; IS________OPM-NEXT: [[TMP9:%.*]] = call noalias i8* @malloc(i64 noundef 4) ; CHECK-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 4, align 1
; IS________OPM-NEXT: [[TMP10:%.*]] = bitcast i8* [[TMP9]] to i32* ; CHECK-NEXT: [[TMP9:%.*]] = bitcast i8* [[DOTH2S]] to i32*
; IS________OPM-NEXT: br label [[TMP4]] ; CHECK-NEXT: br label [[TMP4]]
; IS________OPM: 11: ; CHECK: 10:
; IS________OPM-NEXT: ret i32 5 ; CHECK-NEXT: ret i32 5
;
; IS________NPM-LABEL: define {{[^@]+}}@malloc_in_loop
; IS________NPM-SAME: (i32 [[TMP0:%.*]]) {
; IS________NPM-NEXT: [[TMP2:%.*]] = alloca i32, align 4
; IS________NPM-NEXT: [[TMP3:%.*]] = alloca i32*, align 8
; IS________NPM-NEXT: store i32 [[TMP0]], i32* [[TMP2]], align 4
; IS________NPM-NEXT: br label [[TMP4:%.*]]
; IS________NPM: 4:
; IS________NPM-NEXT: [[TMP5:%.*]] = load i32, i32* [[TMP2]], align 4
; IS________NPM-NEXT: [[TMP6:%.*]] = add nsw i32 [[TMP5]], -1
; IS________NPM-NEXT: store i32 [[TMP6]], i32* [[TMP2]], align 4
; IS________NPM-NEXT: [[TMP7:%.*]] = icmp sgt i32 [[TMP6]], 0
; IS________NPM-NEXT: br i1 [[TMP7]], label [[TMP8:%.*]], label [[TMP10:%.*]]
; IS________NPM: 8:
; IS________NPM-NEXT: [[DOTH2S:%.*]] = alloca i8, i64 4, align 1
; IS________NPM-NEXT: [[TMP9:%.*]] = bitcast i8* [[DOTH2S]] to i32*
; IS________NPM-NEXT: br label [[TMP4]]
; IS________NPM: 10:
; IS________NPM-NEXT: ret i32 5
; ;
%2 = alloca i32, align 4 %2 = alloca i32, align 4
%3 = alloca i32*, align 8 %3 = alloca i32*, align 8
store i32 %0, i32* %2, align 4 store i32 %0, i32* %2, align 4
br label %4 br label %4
4: ; preds = %8, %1 4: ; preds = %8, %1
%5 = load i32, i32* %2, align 4 %5 = load i32, i32* %2, align 4
▲ Show 20 Lines • Show All 197 Lines • Show Last 20 Lines