This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][test] Update fold-addi-loadstore.ll for D129686
Needs ReviewPublic

Authored by asb on Jul 19 2022, 5:56 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This updates fold-addi-loadstore.ll in preparation for D129686 (posting this for reference rather than committing directly as it's not clear we want to go in the D129686 direction). This patch:

  • Prepares for having difference prefixes to show altered codegen choices depending on the presence of the compressed extension
  • Adds a new test case for accessing multiple offsets of an array

Diff Detail

Event Timeline

asb created this revision.Jul 19 2022, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2022, 5:56 AM
asb requested review of this revision.Jul 19 2022, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2022, 5:56 AM
reames added a subscriber: reames.Jan 30 2023, 12:14 PM
reames added inline comments.
llvm/test/CodeGen/RISCV/fold-addi-loadstore.ll
242

I think this case is interesting and should land. I'd encourage you to add a case with a larger alignment on the global (or maybe just the load?) to show that if we have alignment info, we can optimize the codegen.

luke957 removed a subscriber: luke957.Feb 2 2023, 11:31 PM