In this patch I am trying to increase our vectorisation test coverage
by adding extra RUN lines to all tests that don't currently use
tail-folding.
Details
- Reviewers
sdesmalen kmclaughlin CarolineConcatto
Diff Detail
Event Timeline
Hi all, I realise this is a big patch. All I'm doing is adding RUN lines to existing tests so there is no functional change, although I did have to tweak some of the CHECK lines so that I could sometimes share the same CHECK line between RUN lines. If you feel this patch is too big to review I'm happy to split it up into smaller ones!
- Updated tests to only include those tests that would fail with tail-folding enabled by default. These tests are a subset of those changed in D129137
Hey David,
About the manual changes, why not use the python script to add the extra check-lines for tail folding?
So for many of the existing tests, e.g. scalable-reductions.ll, we've tried in the past to keep the number of CHECK lines to a minimum because most of the CHECK lines aren't required for the thing we want to test.The vectoriser generates lots of preheader instructions, plus it leaves in a lot of unnecessary code after the vector loop too. However, this does place more burden on the engineer (i.e. me in this case!) to hand-write the CHECK lines. I do think it makes the tests a bit more readable, although that's just my opinion!