This patch adds constant folder for Log1pOp which only supports single and double precision floating-point.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D129979
[mlir][Math] Add constant folder for Log1pOp. ClosedPublic Authored by jacquesguan on Jul 17 2022, 7:39 PM.
Details Summary This patch adds constant folder for Log1pOp which only supports single and double precision floating-point.
Diff Detail
Event Timeline
This revision is now accepted and ready to land.Jul 18 2022, 12:36 AM Closed by commit rGc3d856bf58bf: [mlir][Math] Add constant folder for Log1pOp. (authored by jacquesguan). · Explain WhyJul 20 2022, 12:18 AM This revision was automatically updated to reflect the committed changes. jacquesguan marked an inline comment as done.
Revision Contents
Diff 446056 mlir/include/mlir/Dialect/Math/IR/MathOps.td
mlir/lib/Dialect/Math/IR/MathOps.cpp
mlir/test/Dialect/Math/canonicalize.mlir
|
This requires a comment. The log1p function wouldn't be defined for any number <= -1 since 1 + x <= 0. Trying to understand why this check is just for all negative a as opposed to a <= -1?