[test-suite] Update the test suite for changes to -Wint-conversion

[aaron.ballman]

Summary

This updates the test suite to ignore -Wint-conversion warnings which have been upgraded to an error by https://reviews.llvm.org/D129881. Note, this warning already exists and is on by default, so landing this before D129881 is harmless even if that review is rejected.

[aaron.ballman]

Ping

[MaskRay]

Thanks! This is similar to D123241

[RKSimon]

@aaron.ballman It looks like this broke the clang-ppc64-aix buildbot https://lab.llvm.org/buildbot/#/builders/214

/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/sandbox/test-suite/tools/timeit --summary MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o.time /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/clang -DNDEBUG  -D_XOPEN_SOURCE=700 -O3 -DNDEBUG   -w -Werror=date-time -ffp-contract=off -Wno-implicit-function-declaration -Wno-implicit-int -D__USE_MISC -D__USE_GNU -D__USE_SVID -D__USE_XOPEN_EXTENDED -D__USE_XOPEN -Dunix -MD -MT MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o -MF MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o.d -o MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o   -c /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/test-suite/MultiSource/Applications/siod/slibu.c
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/test-suite/MultiSource/Applications/siod/slibu.c:1799:9: error: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion]
 result = getpass(NULLP(lprompt) ? "" : get_c_string(lprompt));
        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[aaron.ballman]

In D129891#3674373, @RKSimon wrote:

@aaron.ballman It looks like this broke the clang-ppc64-aix buildbot https://lab.llvm.org/buildbot/#/builders/214

/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/sandbox/test-suite/tools/timeit --summary MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o.time /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/clang -DNDEBUG  -D_XOPEN_SOURCE=700 -O3 -DNDEBUG   -w -Werror=date-time -ffp-contract=off -Wno-implicit-function-declaration -Wno-implicit-int -D__USE_MISC -D__USE_GNU -D__USE_SVID -D__USE_XOPEN_EXTENDED -D__USE_XOPEN -Dunix -MD -MT MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o -MF MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o.d -o MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o   -c /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/test-suite/MultiSource/Applications/siod/slibu.c
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/test-suite/MultiSource/Applications/siod/slibu.c:1799:9: error: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion]
 result = getpass(NULLP(lprompt) ? "" : get_c_string(lprompt));
        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks for the notice, I've fixed that in f47d83408790e3558e5fdb871ba66996b1b1183d; I'll watch the AIX bot to make sure this was the only failure that needs fixing.

MultiSource/Applications/Burg/CMakeLists.txt

 list(APPEND CPPFLAGS -DDEBUG)
-list(APPEND CFLAGS -std=gnu89)
+list(APPEND CFLAGS -std=gnu89 -Wno-int-conversion)
 set(RUN_OPTIONS < sample.gr)
 
 include_directories(${CMAKE_CURRENT_BINARY_DIR})
 llvm_multisource(burg)
 llvm_test_data(burg sample.gr)

MultiSource/Applications/Burg/Makefile

 LEVEL = ../../..
 
 PROG     = burg
 CPPFLAGS = -DDEBUG
-CFLAGS  += -std=gnu89
+CFLAGS  += -std=gnu89 -Wno-int-conversion
 LDFLAGS  = -lstdc++
 
 STDIN_FILENAME = $(PROJ_SRC_DIR)/sample.gr
 
 include $(LEVEL)/Makefile.config
 
 Source  := $(ExtraSource) $(wildcard $(PROJ_SRC_DIR)/*.c)
 

MultiSource/Benchmarks/Prolangs-C/assembler/CMakeLists.txt

+list(APPEND CFLAGS -Wno-int-conversion)
 list(APPEND LDFLAGS -lm)
 llvm_multisource(assembler)

MultiSource/Benchmarks/Prolangs-C/assembler/Makefile

 LEVEL = ../../../..
 
 PROG = assembler
 LDFLAGS = -lm
+CFLAGS += -Wno-int-conversion
 include $(LEVEL)/MultiSource/Makefile.multisrc
 

MultiSource/Benchmarks/Prolangs-C/bison/CMakeLists.txt

-list(APPEND CFLAGS -Wno-implicit-function-declaration -Wno-implicit-int)
+list(APPEND CFLAGS -Wno-implicit-function-declaration -Wno-implicit-int -Wno-int-conversion)
 set(RUN_OPTIONS parse.y.in -v)
 llvm_multisource(mybison)
 llvm_test_data(mybison parse.y.in)

MultiSource/Benchmarks/Prolangs-C/bison/Makefile

 LEVEL = ../../../..
 
-CFLAGS += -Wno-implicit-function-declaration -Wno-implicit-int
+CFLAGS += -Wno-implicit-function-declaration -Wno-implicit-int -Wno-int-conversion
 
 PROG = mybison
 RUN_OPTIONS = $(PROJ_SRC_DIR)/parse.y.in -v
 include $(LEVEL)/MultiSource/Makefile.multisrc
 

MultiSource/Benchmarks/Prolangs-C/football/CMakeLists.txt

+list(APPEND CFLAGS -Wno-int-conversion)
 llvm_multisource(football)

MultiSource/Benchmarks/Prolangs-C/football/Makefile

 LEVEL = ../../../..
 
 PROG = football
+CFLAGS += -Wno-int-conversion
 include $(LEVEL)/MultiSource/Makefile.multisrc
 

MultiSource/Benchmarks/Prolangs-C/unix-smail/CMakeLists.txt

+list(APPEND CFLAGS -Wno-int-conversion)
 set(RUN_OPTIONS -v ALL < main.c)
 llvm_multisource(unix-smail)
 llvm_test_data(unix-smail main.c)

MultiSource/Benchmarks/Prolangs-C/unix-smail/Makefile

 LEVEL = ../../../..
 
 PROG = unix-smail
+CFLAGS += -Wno-int-conversion
 RUN_OPTIONS = -v ALL
 STDIN_FILENAME = $(PROJ_SRC_DIR)/main.c
 
 include $(LEVEL)/MultiSource/Makefile.multisrc
 

MultiSource/Benchmarks/TSVC/Recurrences-flt/CMakeLists.txt

 list(APPEND LDFLAGS -lm)
-list(APPEND CFLAGS -std=gnu99)
+list(APPEND CFLAGS -std=gnu99 -Wno-int-conversion)
 set(RUN_OPTIONS 20000 5)
 llvm_multisource(Recurrences-flt)

MultiSource/Benchmarks/TSVC/Recurrences-flt/Makefile

 LEVEL = ../../../..
 
 PROG     = Recurrences-flt
 LDFLAGS  = -lm
-CFLAGS += -std=gnu99
+CFLAGS += -std=gnu99 -Wno-int-conversion
 RUN_OPTIONS = 20000 5
 include $(LEVEL)/MultiSource/Makefile.multisrc
 

MultiSource/Benchmarks/VersaBench/beamformer/CMakeLists.txt

+list(APPEND CFLAGS -Wno-int-conversion)
 list(APPEND LDFLAGS -lm)
 if(LARGE_PROBLEM_SIZE)
   set(RUN_OPTIONS -i 400)
 else()
   if(SMALL_PROBLEM_SIZE)
     set(RUN_OPTIONS -i 25)
   else()
     set(RUN_OPTIONS -i 140)
   endif()
 endif()
 set(HASH_PROGRAM_OUTPUT 1)
 add_definitions(-DFP_ABSTOLERANCE=1e-5)
 llvm_multisource(beamformer)

MultiSource/Benchmarks/VersaBench/beamformer/Makefile

 LEVEL = ../../../..
 LDFLAGS += -lm
-CFLAGS += -DFP_ABSTOLERANCE=1e-5
+CFLAGS += -DFP_ABSTOLERANCE=1e-5 -Wno-int-conversion
 
 PROG     = beamformer
 ifdef LARGE_PROBLEM_SIZE
 RUN_OPTIONS = -i 400
 else 
 ifdef SMALL_PROBLEM_SIZE
 RUN_OPTIONS = -i 25
 else
 RUN_OPTIONS = -i 140
 endif
 endif
 HASH_PROGRAM_OUTPUT = 1
 
 include $(LEVEL)/MultiSource/Makefile.multisrc
 

SingleSource/Regression/C/gcc-c-torture/execute/CMakeLists.txt

 add_subdirectory(ieee)
 
 # GCC C Torture Suite is conventionally run without warnings
-list(APPEND CFLAGS -Wno-implicit-int -Wno-implicit-function-declaration -w)
+list(APPEND CFLAGS -Wno-implicit-int -Wno-int-conversion -Wno-implicit-function-declaration -w)
 
 set(TestsToSkip)
 
 ##
 ## Main Test Blacklist for Clang
 ##
 
 # Tests with features unsupported by Clang (usually GCC extensions)