This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Update the test suite for changes to -Wint-conversion
ClosedPublic

Authored by aaron.ballman on Jul 15 2022, 12:09 PM.

Details

Summary

This updates the test suite to ignore -Wint-conversion warnings which have been upgraded to an error by https://reviews.llvm.org/D129881. Note, this warning already exists and is on by default, so landing this before D129881 is harmless even if that review is rejected.

Diff Detail

Repository
rT test-suite

Event Timeline

aaron.ballman created this revision.Jul 15 2022, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2022, 12:09 PM
aaron.ballman requested review of this revision.Jul 15 2022, 12:09 PM
MaskRay accepted this revision.Jul 22 2022, 12:15 PM
MaskRay added a subscriber: MaskRay.

Thanks! This is similar to D123241

This revision is now accepted and ready to land.Jul 22 2022, 12:15 PM

@aaron.ballman It looks like this broke the clang-ppc64-aix buildbot https://lab.llvm.org/buildbot/#/builders/214

/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/sandbox/test-suite/tools/timeit --summary MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o.time /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/clang -DNDEBUG  -D_XOPEN_SOURCE=700 -O3 -DNDEBUG   -w -Werror=date-time -ffp-contract=off -Wno-implicit-function-declaration -Wno-implicit-int -D__USE_MISC -D__USE_GNU -D__USE_SVID -D__USE_XOPEN_EXTENDED -D__USE_XOPEN -Dunix -MD -MT MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o -MF MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o.d -o MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o   -c /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/test-suite/MultiSource/Applications/siod/slibu.c
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/test-suite/MultiSource/Applications/siod/slibu.c:1799:9: error: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion]
 result = getpass(NULLP(lprompt) ? "" : get_c_string(lprompt));
        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@aaron.ballman It looks like this broke the clang-ppc64-aix buildbot https://lab.llvm.org/buildbot/#/builders/214

/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/sandbox/test-suite/tools/timeit --summary MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o.time /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/clang -DNDEBUG  -D_XOPEN_SOURCE=700 -O3 -DNDEBUG   -w -Werror=date-time -ffp-contract=off -Wno-implicit-function-declaration -Wno-implicit-int -D__USE_MISC -D__USE_GNU -D__USE_SVID -D__USE_XOPEN_EXTENDED -D__USE_XOPEN -Dunix -MD -MT MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o -MF MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o.d -o MultiSource/Applications/siod/CMakeFiles/siod.dir/slibu.c.o   -c /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/test-suite/MultiSource/Applications/siod/slibu.c
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/test-suite/MultiSource/Applications/siod/slibu.c:1799:9: error: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion]
 result = getpass(NULLP(lprompt) ? "" : get_c_string(lprompt));
        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks for the notice, I've fixed that in f47d83408790e3558e5fdb871ba66996b1b1183d; I'll watch the AIX bot to make sure this was the only failure that needs fixing.