[flang] Add dump-symbols option to bbc

[clementval]

Summary

Restore the --dump-symbols option in the bbc
tool.

[PeteSteinfeld]

I notice that other dump options have names that include "debug", for example, "-fdebug-dump-pre-fir". I have no strong preference which way to go, other than we should be consistent. You might want to talk to Jean before submitting these changes.

flang/test/Semantics/typeinfo01.f90

2

Did you mean to include this line?

It seems to be causing check-flang to fail.

[clementval]

Fix bbc run line

[clementval]

In D129850#3655319, @PeteSteinfeld wrote:

I notice that other dump options have names that include "debug", for example, "-fdebug-dump-pre-fir". I have no strong preference which way to go, other than we should be consistent. You might want to talk to Jean before submitting these changes.

In bbc options do not have the debug since it's a dev tool. dump-symbol was actually present in fir-dev with the same name. I do not have strong opinion here for the name.

flang/test/Semantics/typeinfo01.f90

2

Yes but it had a mistake. Should be fixed now.

[PeteSteinfeld]

flang/test/Semantics/typeinfo01.f90

2

I don't see any changes from the previous version. Did you leave out a step?

[clementval]

Fix failing test

[clementval]

flang/test/Semantics/typeinfo01.f90

2

The change was %bbc -> bbc. There was still an error and it should pass now.

[jeanPerier]

LGTM

flang/test/Semantics/typeinfo01.f90

+!RUN: bbc --dump-symbols %s | FileCheck %s
 !RUN: %flang_fc1 -fdebug-dump-symbols %s | FileCheck %s
 ! Tests for derived type runtime descriptions
 
 module m01
   type :: t1
     integer :: n
   end type
 !CHECK: Module scope: m01
 !CHECK: .c.t1, SAVE, TARGET (CompilerCreated, ReadOnly): ObjectEntity type: TYPE(component) shape: 0_8:0_8 init:[component::component(name=.n.n,genre=1_1,category=0_1,kind=4_1,rank=0_1,offset=0_8,characterlen=value(genre=1_1,value=0_8),derived=NULL(),lenvalue=NULL(),bounds=NULL(),initialization=NULL())]

flang/tools/bbc/bbc.cpp

 static llvm::cl::opt<bool> warnStdViolation("Mstandard",
                                             llvm::cl::desc("emit warnings"),
                                             llvm::cl::init(false));
 
 static llvm::cl::opt<bool> warnIsError("Werror",
                                        llvm::cl::desc("warnings are errors"),
                                        llvm::cl::init(false));
 
+static llvm::cl::opt<bool> dumpSymbols("dump-symbols",
+                                       llvm::cl::desc("dump the symbol table"),
+                                       llvm::cl::init(false));
+
 static llvm::cl::opt<bool> pftDumpTest(
     "pft-test",
     llvm::cl::desc("parse the input, create a PFT, dump it, and exit"),
     llvm::cl::init(false));
 
 static llvm::cl::opt<bool> enableOpenMP("fopenmp",
                                         llvm::cl::desc("enable openmp"),
                                         llvm::cl::init(false));
static mlir::LogicalResult convertFortranSourceToMLIR(
   if (!semantics.AnyFatalError()) {
     tables =
         Fortran::semantics::BuildRuntimeDerivedTypeTables(semanticsContext);
     if (!tables.schemata)
       llvm::errs() << programPrefix
                    << "could not find module file for __fortran_type_info\n";
   }
 
+  if (dumpSymbols) {
+    semantics.DumpSymbols(llvm::outs());
+    return mlir::success();
+  }
+
   if (pftDumpTest) {
     if (auto ast = Fortran::lower::createPFT(parseTree, semanticsContext)) {
       Fortran::lower::dumpPFT(llvm::outs(), *ast);
       return mlir::success();
     }
     llvm::errs() << "Pre FIR Tree is NULL.\n";
     return mlir::failure();
   }