This is an archive of the discontinued LLVM Phabricator instance.

[clang][test] fix typo in fn attr
ClosedPublic

Authored by nickdesaulniers on Jul 13 2022, 1:40 PM.

Details

Summary

While testing backports of
https://reviews.llvm.org/D129572#inline-1245936
commit 2240d72f15f3 ("[X86] initial -mfunction-return=thunk-extern support")
I noticed that one of my unit tests mistyped a function attribute. The
unit test was intended to test fn attr merging behavior, but with the
typo it was not. Small fixup.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 1:40 PM
nickdesaulniers requested review of this revision.Jul 13 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 1:40 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
clang/test/CodeGen/attr-function-return.c
18

probably don't want to reset KEEP

24

probably don't want to reset EXTERN

This revision is now accepted and ready to land.Jul 14 2022, 4:10 AM
  • don't reset captured vars, that was a copy+paste mistake I made in the original patch
This revision was landed with ongoing or failed builds.Jul 14 2022, 9:53 AM
This revision was automatically updated to reflect the committed changes.