This is an archive of the discontinued LLVM Phabricator instance.

Differential D129587

[Support] Enable BLAKE3 .note.GNU-stack sections on FreeBSD
Needs RevisionPublic

Authored by dim on Jul 12 2022, 1:12 PM.

Details

Reviewers
akyrtzi
emaste
MaskRay
rnk
Summary

Several .S files for accelerating BLAKE3 have directives to add
.note.GNU-stack sections on Linux, to signal a non-executable stack.
Enable these for FreeBSD too.

Diff Detail

Event Timeline

dim created this revision.Jul 12 2022, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2022, 1:12 PM
Herald added subscribers: StephenFan, hiraditya, krytarowski, arichardson. · View Herald Transcript
dim requested review of this revision.Jul 12 2022, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2022, 1:12 PM
MaskRay added a comment.EditedJul 12 2022, 1:29 PM

lld ignores input sections .note.GNU-stack and just default to non-executable PT_GNU_STACK. I think this is the direction for GNU ld, too.
Therefore I think this is unneeded. If you still want to do it, updating the upstream first is the right direction.

Harbormaster completed remote builds in B174962: Diff 444059.Jul 12 2022, 3:08 PM
emaste added a comment.Jul 25 2022, 1:43 PM

I got the same sort of change in upstream liblzma, https://git.tukaani.org/?p=xz.git;a=commit;h=865e0a3689a25a7ee8eecae1a34c1775e3aa676e

MaskRay requested changes to this revision.Jul 25 2022, 2:13 PM

Request changes with aforementioned reasons.

In D129587#3677362, @emaste wrote:

I got the same sort of change in upstream liblzma, https://git.tukaani.org/?p=xz.git;a=commit;h=865e0a3689a25a7ee8eecae1a34c1775e3aa676e

If FreeBSD still uses binutils somehow, you may change it to ignore .note.GNU-stack. This section is mostly not really used at this point.

binutils is moving toward this goal too https://sourceware.org/bugzilla/show_bug.cgi?id=29072#c9

This revision now requires changes to proceed.Jul 25 2022, 2:13 PM

Revision Contents

Diff 444059

llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_unix.S

#if defined(__x86_64__) #if defined(__x86_64__)
#if defined(__ELF__) && defined(__linux__) #if defined(__ELF__) && (defined(__linux__) || defined(__FreeBSD__))
.section .note.GNU-stack,"",%progbits .section .note.GNU-stack,"",%progbits
#endif #endif
#if defined(__ELF__) && defined(__CET__) && defined(__has_include) #if defined(__ELF__) && defined(__CET__) && defined(__has_include)
#if __has_include(<cet.h>) #if __has_include(<cet.h>)
#include <cet.h> #include <cet.h>
#endif #endif
#endif #endif
▲ Show 20 Lines • Show All 1,815 Lines • Show Last 20 Lines

llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_unix.S

#if defined(__x86_64__) #if defined(__x86_64__)
#if defined(__ELF__) && defined(__linux__) #if defined(__ELF__) && (defined(__linux__) || defined(__FreeBSD__))
.section .note.GNU-stack,"",%progbits .section .note.GNU-stack,"",%progbits
#endif #endif
#if defined(__ELF__) && defined(__CET__) && defined(__has_include) #if defined(__ELF__) && defined(__CET__) && defined(__has_include)
#if __has_include(<cet.h>) #if __has_include(<cet.h>)
#include <cet.h> #include <cet.h>
#endif #endif
#endif #endif
▲ Show 20 Lines • Show All 2,590 Lines • Show Last 20 Lines

llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_unix.S

#if defined(__x86_64__) #if defined(__x86_64__)
#if defined(__ELF__) && defined(__linux__) #if defined(__ELF__) && (defined(__linux__) || defined(__FreeBSD__))
.section .note.GNU-stack,"",%progbits .section .note.GNU-stack,"",%progbits
#endif #endif
#if defined(__ELF__) && defined(__CET__) && defined(__has_include) #if defined(__ELF__) && defined(__CET__) && defined(__has_include)
#if __has_include(<cet.h>) #if __has_include(<cet.h>)
#include <cet.h> #include <cet.h>
#endif #endif
#endif #endif
▲ Show 20 Lines • Show All 2,296 Lines • Show Last 20 Lines

llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_unix.S

#if defined(__x86_64__) #if defined(__x86_64__)
#if defined(__ELF__) && defined(__linux__) #if defined(__ELF__) && (defined(__linux__) || defined(__FreeBSD__))
.section .note.GNU-stack,"",%progbits .section .note.GNU-stack,"",%progbits
#endif #endif
#if defined(__ELF__) && defined(__CET__) && defined(__has_include) #if defined(__ELF__) && defined(__CET__) && defined(__has_include)
#if __has_include(<cet.h>) #if __has_include(<cet.h>)
#include <cet.h> #include <cet.h>
#endif #endif
#endif #endif
▲ Show 20 Lines • Show All 2,033 Lines • Show Last 20 Lines