Page MenuHomePhabricator
Differential D129159

[JITLink][RISCV] Ignore R_RISCV_RELAX and check R_RISCV_ALIGN
ClosedPublic
Actions

Authored by Hahnfeld on Jul 5 2022, 1:42 PM.

Details

Reviewers
lhames
StephenFan
fourdim
Commits
rGf5b5398ebf7d: [JITLink][RISCV] Ignore R_RISCV_RELAX and check R_RISCV_ALIGN
Summary

It is fine to not implement and ignore linker relaxation for now, but
we need to check the alignment. Luckily, an alignment of only 2 bytes
is the most common case when interpreting C++ code in clang-repl, and
already guaranteed by the length of compressed instructions.

Diff Detail

Event Timeline

Hahnfeld created this revision.Jul 5 2022, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 1:42 PM
Herald added subscribers: sunshaoce, VincentWu, luke957 and 29 others. · View Herald Transcript
Hahnfeld requested review of this revision.Jul 5 2022, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 1:42 PM
Herald added subscribers: llvm-commits, pcwang-thead, eopXD. · View Herald Transcript
Harbormaster completed remote builds in B173764: Diff 442389.Jul 5 2022, 2:55 PM
StephenFan accepted this revision.Jul 5 2022, 7:50 PM

LGTM.

This revision is now accepted and ready to land.Jul 5 2022, 7:50 PM
This revision was landed with ongoing or failed builds.Jul 6 2022, 9:09 AM
Closed by commit rGf5b5398ebf7d: [JITLink][RISCV] Ignore R_RISCV_RELAX and check R_RISCV_ALIGN (authored by Hahnfeld). · Explain Why
This revision was automatically updated to reflect the committed changes.
Hahnfeld added a commit: rGf5b5398ebf7d: [JITLink][RISCV] Ignore R_RISCV_RELAX and check R_RISCV_ALIGN.

Revision Contents
Changeset List

PathSize
llvm/
lib/
ExecutionEngine/
JITLink/
30 lines

Diff 442604

View Options

llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp

Loading...