This is an archive of the discontinued LLVM Phabricator instance.

[JITLink][RISCV] Ignore R_RISCV_RELAX and check R_RISCV_ALIGN
ClosedPublic

Authored by Hahnfeld on Jul 5 2022, 1:42 PM.

Details

Summary

It is fine to not implement and ignore linker relaxation for now, but
we need to check the alignment. Luckily, an alignment of only 2 bytes
is the most common case when interpreting C++ code in clang-repl, and
already guaranteed by the length of compressed instructions.

Diff Detail

Event Timeline

Hahnfeld created this revision.Jul 5 2022, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 1:42 PM
Hahnfeld requested review of this revision.Jul 5 2022, 1:42 PM
This revision is now accepted and ready to land.Jul 5 2022, 7:50 PM
This revision was landed with ongoing or failed builds.Jul 6 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.

I made a mistake in thinking that most R_RISCV_ALIGN can be ignored - they cannot. I'm correcting this in https://reviews.llvm.org/D149552.