Page MenuHomePhabricator

[Libomptarget][NFC] Make Libomptarget use the LLVM naming convention
ClosedPublic

Authored by jhuber6 on Jul 1 2022, 8:55 AM.

Details

Summary

Libomptarget grew out of a project that was originally not in LLVM. As
we develop libomptarget this has led to an increasingly large clash
between the naming conventions used. This patch fixes most of the
variable names that did not confrom to the LLVM standard, that is
VariableName for variables and functionName for functions.

This patch was primarily done using my editor's linting messages, if
there are any issues I missed arising from the automation let me know.

Diff Detail

Event Timeline

jhuber6 created this revision.Jul 1 2022, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2022, 8:55 AM
jhuber6 requested review of this revision.Jul 1 2022, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2022, 8:55 AM
saiislam accepted this revision.Jul 5 2022, 10:38 AM

LGTM!

Leftovers, if any, can be covered in a follow-up patch.

This revision is now accepted and ready to land.Jul 5 2022, 10:38 AM
tianshilei1992 added inline comments.Jul 5 2022, 10:41 AM
openmp/libomptarget/include/omptarget.h
207–221

we probably keep those C APIs unchanged as the API names already don't follow LLVM standard.

jhuber6 added inline comments.Jul 5 2022, 10:42 AM
openmp/libomptarget/include/omptarget.h
207–221

Yes, I was somewhat careful to avoid renaming anything that was used outside of libomptarget.