This is an archive of the discontinued LLVM Phabricator instance.

[flang] Fix "not yet implemented" message for CHARACTER MIN/MAX
ClosedPublic

Authored by clementval on Jun 30 2022, 8:30 AM.

Details

Summary

The check to see if the arguments for the MIN/MAX intrinsics were of CHARACTER
type was not handling assumed length characters. In this case, the FIR type is
"!fir.ref<!fir.char<1,?>>".

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Peter Steinfeld <psteinfeld@nvidia.com>

Diff Detail

Event Timeline

clementval created this revision.Jun 30 2022, 8:30 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 30 2022, 8:30 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Jun 30 2022, 8:30 AM
PeteSteinfeld accepted this revision.Jun 30 2022, 9:09 AM

All builds and tests correctly and looks good.

This revision is now accepted and ready to land.Jun 30 2022, 9:09 AM
This revision was landed with ongoing or failed builds.Jun 30 2022, 9:13 AM
This revision was automatically updated to reflect the committed changes.