This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Add support for DW_AT_call_pc/DW_AT_call_return_pc
ClosedPublic

Authored by ayermolo on Jun 24 2022, 6:54 AM.

Details

Summary

DWARF 5 added two new attributes DW_AT_call_pc and DW_AT_call_return_pc.
Adding support for them.

Diff Detail

Event Timeline

ayermolo created this revision.Jun 24 2022, 6:54 AM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.Jun 24 2022, 6:54 AM
Herald added a project: Restricted Project. · View Herald Transcript
maksfb accepted this revision.Jun 24 2022, 12:28 PM

LGTM

bolt/lib/Rewrite/DWARFRewriter.cpp
483
483

You can use dwarf::AttributeString() to convert attribute value to string. Not sure if that will be enough or worth it to eliminate the Entry parameter.

This revision is now accepted and ready to land.Jun 24 2022, 12:28 PM